Skip to content

Conversation

@DiegoCivi
Copy link
Contributor

@DiegoCivi DiegoCivi commented Oct 15, 2025

Fix Fuzzer workflow

Closes #2228

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@DiegoCivi DiegoCivi added the pipelines This PR/issue is exclusively about improving our CI label Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.723 s ±  0.092 s    [User: 23.862 s, System: 0.858 s]
  Range (min … max):   24.658 s … 24.788 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     24.628 s ±  0.035 s    [User: 23.786 s, System: 0.838 s]
  Range (min … max):   24.603 s … 24.653 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.426 s ±  0.059 s    [User: 23.928 s, System: 0.873 s]
  Range (min … max):   13.384 s … 13.467 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.432 s ±  0.016 s    [User: 23.883 s, System: 0.899 s]
  Range (min … max):   13.420 s … 13.444 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.229 s ±  0.395 s    [User: 36.868 s, System: 1.067 s]
  Range (min … max):    9.949 s … 10.509 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.176 s ±  0.179 s    [User: 36.516 s, System: 1.079 s]
  Range (min … max):   10.049 s … 10.303 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.01 ± 0.04 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):      9.931 s ±  0.064 s    [User: 37.064 s, System: 1.118 s]
  Range (min … max):    9.886 s …  9.977 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.957 s ±  0.026 s    [User: 36.895 s, System: 1.091 s]
  Range (min … max):    9.938 s …  9.975 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.937 s ±  0.207 s    [User: 37.320 s, System: 1.119 s]
  Range (min … max):    9.791 s … 10.083 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.041 s ±  0.161 s    [User: 36.979 s, System: 1.109 s]
  Range (min … max):    9.928 s … 10.155 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.03 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.131 s ±  0.121 s    [User: 37.191 s, System: 1.197 s]
  Range (min … max):   10.045 s … 10.216 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.142 s ±  0.055 s    [User: 37.152 s, System: 1.185 s]
  Range (min … max):   10.103 s … 10.181 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 16


@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.125 ± 0.045 2.069 2.244 1.02 ± 0.02
head big_factorial 2.092 ± 0.025 2.065 2.150 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.030 ± 0.029 2.003 2.101 1.01 ± 0.02
head big_fibonacci 2.016 ± 0.013 1.999 2.039 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.277 ± 0.188 7.042 7.648 1.01 ± 0.03
head blake2s_integration_benchmark 7.223 ± 0.069 7.060 7.285 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.141 ± 0.017 2.113 2.167 1.00 ± 0.01
head compare_arrays_200000 2.140 ± 0.015 2.120 2.170 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.438 ± 0.009 1.424 1.454 1.01 ± 0.01
head dict_integration_benchmark 1.426 ± 0.018 1.398 1.459 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.202 ± 0.013 1.183 1.220 1.00
head field_arithmetic_get_square_benchmark 1.205 ± 0.016 1.180 1.238 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.343 ± 0.046 7.252 7.406 1.00 ± 0.01
head integration_builtins 7.314 ± 0.085 7.165 7.418 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.373 ± 0.094 7.212 7.506 1.00
head keccak_integration_benchmark 7.407 ± 0.097 7.229 7.481 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.124 ± 0.023 2.091 2.156 1.00 ± 0.01
head linear_search 2.115 ± 0.011 2.096 2.134 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.509 ± 0.020 1.488 1.545 1.02 ± 0.02
head math_cmp_and_pow_integration_benchmark 1.486 ± 0.012 1.466 1.500 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.440 ± 0.010 1.429 1.456 1.00
head math_integration_benchmark 1.442 ± 0.012 1.422 1.460 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.205 ± 0.012 1.184 1.221 1.00
head memory_integration_benchmark 1.207 ± 0.012 1.187 1.225 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.525 ± 0.007 1.514 1.537 1.01 ± 0.01
head operations_with_data_structures_benchmarks 1.515 ± 0.007 1.504 1.532 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 522.0 ± 1.7 519.2 523.8 1.00
head pedersen 524.7 ± 4.1 520.4 535.0 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 595.5 ± 3.8 590.6 604.3 1.00 ± 0.01
head poseidon_integration_benchmark 595.3 ± 3.0 590.6 598.9 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.770 ± 0.014 1.759 1.802 1.01 ± 0.01
head secp_integration_benchmark 1.761 ± 0.010 1.747 1.786 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 645.0 ± 4.8 638.9 656.7 1.00 ± 0.01
head set_integration_benchmark 643.9 ± 3.0 639.1 649.5 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.146 ± 0.045 4.087 4.224 1.00
head uint256_integration_benchmark 4.158 ± 0.066 4.054 4.312 1.00 ± 0.02

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (a3f1ae9) to head (5595669).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2232   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files         104      104           
  Lines       44027    44027           
=======================================
  Hits        42566    42566           
  Misses       1461     1461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

schedule:
# At the end of every day
- cron: "0 0 * * *"
workflow_dispatch:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this so we can run it manually if we ever find ourselves trying to debug it again and don't have to wait for the specific time it runs

arbitrary = { version = "1.3.0", features = ["derive"] }
cairo-vm = { path = "../vm", features = ["test_utils"] }
honggfuzz = "0.5.55"
honggfuzz = "=0.5.58"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the CI we are using cargo hfuzz 0.5.58 so it has to match with honggfuzz

@DiegoCivi DiegoCivi marked this pull request as ready for review October 16, 2025 18:37
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabrielbosio gabrielbosio added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit 093706e Oct 17, 2025
92 checks passed
@gabrielbosio gabrielbosio deleted the fix-fuzzer branch October 17, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipelines This PR/issue is exclusively about improving our CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fuzzer Workflow fails

4 participants