Skip to content

Conversation

@DiegoCivi
Copy link
Contributor

@DiegoCivi DiegoCivi commented Sep 19, 2025

Update cargo-all-features use in CI

Description

In the CI we are using the latest release of the tool cargo-all-features (we are installing it with taiki-e/install-action@v2 which gets the latest release). A change was made so instead of doing cargo check-all-features now we need to do cargo all-features check. (cargo-all-features example)

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@DiegoCivi DiegoCivi added the pipelines This PR/issue is exclusively about improving our CI label Sep 19, 2025
@github-actions
Copy link

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.826 s ±  0.011 s    [User: 23.988 s, System: 0.835 s]
  Range (min … max):   24.819 s … 24.834 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     24.679 s ±  0.022 s    [User: 23.862 s, System: 0.814 s]
  Range (min … max):   24.663 s … 24.694 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.01 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.450 s ±  0.016 s    [User: 24.083 s, System: 0.822 s]
  Range (min … max):   13.439 s … 13.462 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.506 s ±  0.045 s    [User: 24.096 s, System: 0.868 s]
  Range (min … max):   13.473 s … 13.538 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):      9.987 s ±  0.047 s    [User: 36.888 s, System: 1.043 s]
  Range (min … max):    9.953 s … 10.020 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.208 s ±  0.419 s    [User: 36.910 s, System: 1.065 s]
  Range (min … max):    9.912 s … 10.504 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.02 ± 0.04 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):      9.954 s ±  0.141 s    [User: 37.235 s, System: 1.056 s]
  Range (min … max):    9.854 s … 10.054 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.145 s ±  0.380 s    [User: 37.085 s, System: 1.035 s]
  Range (min … max):    9.876 s … 10.414 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.02 ± 0.04 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.979 s ±  0.147 s    [User: 36.965 s, System: 1.032 s]
  Range (min … max):    9.875 s … 10.083 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.123 s ±  0.035 s    [User: 37.262 s, System: 1.042 s]
  Range (min … max):   10.098 s … 10.147 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.02 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.041 s ±  0.038 s    [User: 37.347 s, System: 1.130 s]
  Range (min … max):   10.013 s … 10.068 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):      9.955 s ±  0.064 s    [User: 37.347 s, System: 1.136 s]
  Range (min … max):    9.909 s … 10.000 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 16


@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.087 ± 0.018 2.054 2.109 1.00
head big_factorial 2.089 ± 0.027 2.048 2.129 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.029 ± 0.030 1.992 2.094 1.00 ± 0.02
head big_fibonacci 2.019 ± 0.034 1.986 2.103 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.264 ± 0.103 7.153 7.520 1.00
head blake2s_integration_benchmark 7.311 ± 0.326 7.008 8.202 1.01 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.129 ± 0.021 2.105 2.169 1.00
head compare_arrays_200000 2.134 ± 0.020 2.101 2.168 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.411 ± 0.012 1.392 1.427 1.00
head dict_integration_benchmark 1.431 ± 0.021 1.404 1.476 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.197 ± 0.012 1.176 1.226 1.00 ± 0.02
head field_arithmetic_get_square_benchmark 1.194 ± 0.016 1.175 1.231 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.330 ± 0.109 7.184 7.548 1.01 ± 0.02
head integration_builtins 7.260 ± 0.081 7.161 7.350 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.380 ± 0.106 7.223 7.615 1.00
head keccak_integration_benchmark 7.405 ± 0.173 7.224 7.821 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.140 ± 0.017 2.117 2.164 1.00 ± 0.01
head linear_search 2.131 ± 0.024 2.096 2.167 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.483 ± 0.013 1.465 1.506 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.482 ± 0.011 1.471 1.509 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.450 ± 0.013 1.433 1.475 1.00
head math_integration_benchmark 1.451 ± 0.011 1.433 1.467 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.197 ± 0.011 1.181 1.210 1.01 ± 0.01
head memory_integration_benchmark 1.189 ± 0.010 1.176 1.205 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.528 ± 0.020 1.507 1.577 1.00 ± 0.02
head operations_with_data_structures_benchmarks 1.525 ± 0.012 1.515 1.555 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 525.0 ± 3.0 520.5 530.7 1.00
head pedersen 526.7 ± 6.2 521.1 543.3 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 615.4 ± 8.5 603.8 628.9 1.02 ± 0.02
head poseidon_integration_benchmark 605.9 ± 5.2 600.7 619.6 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.772 ± 0.013 1.760 1.796 1.00
head secp_integration_benchmark 1.776 ± 0.021 1.755 1.819 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 641.5 ± 2.1 638.2 644.4 1.00
head set_integration_benchmark 643.7 ± 2.5 638.9 647.2 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.101 ± 0.052 4.032 4.215 1.00
head uint256_integration_benchmark 4.109 ± 0.031 4.053 4.152 1.00 ± 0.01

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (8d716b7) to head (5a8f3d0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2204   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files         104      104           
  Lines       44027    44027           
=======================================
  Hits        42566    42566           
  Misses       1461     1461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DiegoCivi DiegoCivi marked this pull request as ready for review September 19, 2025 13:05
@gabrielbosio gabrielbosio added this pull request to the merge queue Sep 19, 2025
Merged via the queue into main with commit d03e709 Sep 19, 2025
92 of 93 checks passed
@gabrielbosio gabrielbosio deleted the fix-ci-features-check branch September 19, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipelines This PR/issue is exclusively about improving our CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants