Skip to content

Conversation

@JulianGCalderon
Copy link
Contributor

Make MemorySegmentManager's memory field private

To allow the user to keep accessing the memory, we provide some public getters.

Closes #2158

@github-actions
Copy link

github-actions bot commented Aug 11, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.711 s ±  0.435 s    [User: 23.814 s, System: 0.892 s]
  Range (min … max):   24.404 s … 25.019 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     24.207 s ±  0.013 s    [User: 23.324 s, System: 0.880 s]
  Range (min … max):   24.198 s … 24.216 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.02 ± 0.02 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.259 s ±  0.047 s    [User: 23.601 s, System: 0.905 s]
  Range (min … max):   13.226 s … 13.292 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.216 s ±  0.005 s    [User: 23.522 s, System: 0.888 s]
  Range (min … max):   13.212 s … 13.219 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.045 s ±  0.376 s    [User: 36.213 s, System: 1.074 s]
  Range (min … max):    9.779 s … 10.311 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):      9.646 s ±  0.052 s    [User: 36.122 s, System: 1.123 s]
  Range (min … max):    9.609 s …  9.682 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.04 ± 0.04 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.154 s ±  0.276 s    [User: 36.066 s, System: 1.160 s]
  Range (min … max):    9.959 s … 10.349 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.771 s ±  0.367 s    [User: 36.075 s, System: 1.122 s]
  Range (min … max):    9.512 s … 10.030 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.04 ± 0.05 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.939 s ±  0.023 s    [User: 36.639 s, System: 1.208 s]
  Range (min … max):    9.923 s …  9.955 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.866 s ±  0.088 s    [User: 36.268 s, System: 1.167 s]
  Range (min … max):    9.804 s …  9.929 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.066 s ±  0.163 s    [User: 37.057 s, System: 1.198 s]
  Range (min … max):    9.950 s … 10.181 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):      9.894 s ±  0.042 s    [User: 36.359 s, System: 1.267 s]
  Range (min … max):    9.865 s …  9.924 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.02 ± 0.02 times faster than hyper_threading_main threads: 16


@github-actions
Copy link

github-actions bot commented Aug 11, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.096 ± 0.010 2.084 2.111 1.00
head big_factorial 2.113 ± 0.041 2.074 2.220 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.021 ± 0.014 1.998 2.046 1.00 ± 0.01
head big_fibonacci 2.021 ± 0.011 2.008 2.037 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.198 ± 0.123 7.086 7.526 1.00 ± 0.02
head blake2s_integration_benchmark 7.176 ± 0.023 7.144 7.230 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.161 ± 0.032 2.130 2.247 1.00 ± 0.02
head compare_arrays_200000 2.156 ± 0.017 2.137 2.191 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.417 ± 0.011 1.407 1.441 1.00
head dict_integration_benchmark 1.436 ± 0.007 1.424 1.444 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.203 ± 0.010 1.195 1.230 1.00
head field_arithmetic_get_square_benchmark 1.204 ± 0.008 1.191 1.216 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.274 ± 0.033 7.223 7.326 1.00
head integration_builtins 7.300 ± 0.027 7.261 7.343 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.366 ± 0.063 7.274 7.472 1.00
head keccak_integration_benchmark 7.392 ± 0.059 7.330 7.532 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.168 ± 0.018 2.148 2.212 1.00
head linear_search 2.170 ± 0.014 2.146 2.192 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.511 ± 0.019 1.490 1.553 1.00
head math_cmp_and_pow_integration_benchmark 1.516 ± 0.009 1.506 1.538 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.446 ± 0.010 1.430 1.459 1.00
head math_integration_benchmark 1.464 ± 0.010 1.452 1.482 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.215 ± 0.008 1.200 1.227 1.00
head memory_integration_benchmark 1.236 ± 0.031 1.208 1.308 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.528 ± 0.010 1.515 1.550 1.00
head operations_with_data_structures_benchmarks 1.545 ± 0.012 1.529 1.572 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 528.4 ± 2.3 525.8 532.6 1.00
head pedersen 529.4 ± 2.2 526.7 534.0 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 617.8 ± 6.3 608.9 630.2 1.00
head poseidon_integration_benchmark 626.5 ± 3.0 623.1 632.4 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.773 ± 0.004 1.767 1.780 1.00
head secp_integration_benchmark 1.792 ± 0.008 1.782 1.805 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 635.1 ± 12.1 625.6 668.0 1.00
head set_integration_benchmark 677.0 ± 8.8 663.6 688.5 1.07 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.133 ± 0.060 4.070 4.293 1.00 ± 0.02
head uint256_integration_benchmark 4.116 ± 0.042 4.085 4.228 1.00

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.67%. Comparing base (5c48a92) to head (6afefa7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2164   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files         103      103           
  Lines       43944    43990   +46     
=======================================
+ Hits        42483    42529   +46     
  Misses       1461     1461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JulianGCalderon JulianGCalderon marked this pull request as ready for review August 11, 2025 21:20
@JulianGCalderon JulianGCalderon added this pull request to the merge queue Aug 13, 2025
Merged via the queue into main with commit 579c323 Aug 13, 2025
93 checks passed
@JulianGCalderon JulianGCalderon deleted the make-memory-private branch August 13, 2025 21:18
gabrielbosio added a commit that referenced this pull request Aug 14, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert MemorySegmentManager::memory field visibility

4 participants