-
Notifications
You must be signed in to change notification settings - Fork 206
Pin types-rs version to the one set in lockfile #2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Benchmark Results for unmodified programs 🚀
|
aa06faf to
12c200e
Compare
|
|
||
| #### Upcoming Changes | ||
|
|
||
| * chore: Pin types-rs version to the one set in lockfile [#2140](https://github.com/lambdaclass/cairo-vm/pull/2140) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add that types-rs was updated to 0.1.8, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because types-rs was not pinned, it was already updated to 0.1.8 before this PR, so I am not sure this counts as a dependency update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2140 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 103 103
Lines 43568 43568
=======================================
Hits 42118 42118
Misses 1450 1450 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.