Skip to content

Conversation

@gabrielbosio
Copy link
Collaborator

No description provided.

@gabrielbosio gabrielbosio marked this pull request as ready for review May 28, 2025 22:06
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.138 ± 0.033 2.117 2.227 1.00
head big_factorial 2.139 ± 0.018 2.117 2.171 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.070 ± 0.014 2.047 2.086 1.00 ± 0.01
head big_fibonacci 2.060 ± 0.014 2.040 2.078 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.784 ± 0.139 7.680 8.157 1.01 ± 0.02
head blake2s_integration_benchmark 7.733 ± 0.079 7.594 7.823 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.192 ± 0.023 2.174 2.252 1.00 ± 0.01
head compare_arrays_200000 2.192 ± 0.011 2.175 2.210 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.423 ± 0.010 1.410 1.445 1.00
head dict_integration_benchmark 1.425 ± 0.009 1.415 1.443 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.227 ± 0.008 1.217 1.240 1.00
head field_arithmetic_get_square_benchmark 1.230 ± 0.008 1.221 1.239 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.844 ± 0.143 7.715 8.120 1.00 ± 0.02
head integration_builtins 7.815 ± 0.064 7.759 7.955 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.038 ± 0.042 7.991 8.115 1.00
head keccak_integration_benchmark 8.044 ± 0.060 7.981 8.147 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.168 ± 0.012 2.155 2.191 1.00 ± 0.01
head linear_search 2.168 ± 0.012 2.157 2.200 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.517 ± 0.009 1.507 1.531 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.512 ± 0.016 1.503 1.556 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.458 ± 0.006 1.450 1.473 1.00
head math_integration_benchmark 1.461 ± 0.007 1.450 1.470 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.213 ± 0.007 1.205 1.222 1.00
head memory_integration_benchmark 1.217 ± 0.008 1.204 1.230 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.579 ± 0.008 1.569 1.596 1.00
head operations_with_data_structures_benchmarks 1.591 ± 0.020 1.572 1.625 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 536.5 ± 3.2 532.9 544.5 1.00 ± 0.01
head pedersen 536.2 ± 2.2 533.5 541.0 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 632.2 ± 4.1 628.5 639.9 1.00 ± 0.01
head poseidon_integration_benchmark 631.9 ± 3.3 628.8 639.7 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.835 ± 0.011 1.822 1.863 1.01 ± 0.01
head secp_integration_benchmark 1.822 ± 0.006 1.814 1.835 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 683.0 ± 11.3 665.5 700.3 1.09 ± 0.02
head set_integration_benchmark 626.5 ± 1.6 624.9 630.6 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.251 ± 0.044 4.217 4.347 1.00
head uint256_integration_benchmark 4.291 ± 0.065 4.229 4.451 1.01 ± 0.02

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (e163306) to head (590bd97).
Report is 1 commits behind head on 2.x.y.

Additional details and impacted files
@@           Coverage Diff           @@
##            2.x.y    #2107   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files         103      103           
  Lines       43645    43645           
=======================================
  Hits        42190    42190           
  Misses       1455     1455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabrielbosio gabrielbosio enabled auto-merge May 28, 2025 22:29
@gabrielbosio gabrielbosio added this pull request to the merge queue May 28, 2025
Merged via the queue into 2.x.y with commit bf2c2a5 May 28, 2025
93 checks passed
@gabrielbosio gabrielbosio deleted the prepare_2.2.0 branch May 28, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants