-
Notifications
You must be signed in to change notification settings - Fork 206
feat: implemented delete_unaccessed function #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
af680c4 to
96cfd47
Compare
|
Benchmark Results for unmodified programs 🚀
|
f94c831 to
a3c1001
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x.y #2099 +/- ##
=======================================
Coverage 96.65% 96.66%
=======================================
Files 103 103
Lines 43548 43645 +97
=======================================
+ Hits 42093 42190 +97
Misses 1455 1455 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
02d88ce to
7b20139
Compare
7b20139 to
79e6554
Compare
7fe90b9 to
3908d84
Compare
3908d84 to
668dd3b
Compare
JulianGCalderon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Could you add a link to the related OS code in the description?
done |
668dd3b to
a1c9e5f
Compare
done |
Signed-off-by: Dori Medini <[email protected]>
a1c9e5f to
9f2c412
Compare
JulianGCalderon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implemented prevent_segment_execution function
Description:
In the Starknet OS's
bytecode_hash_internal_nodeimplementation, we have this snippet:This PR is to support the above logic: marking a segment as non-executable, and complying with the
assert data_ptr[0] = -1after the hint.Checklist