Skip to content

Avoid installing gmp when executing install-macos.sh #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 14, 2025
Merged

Avoid installing gmp when executing install-macos.sh #2063

Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1baaec8
avoid installing gmp if it is already installed
FrancoGiachetta Apr 7, 2025
8182981
fix
FrancoGiachetta Apr 7, 2025
983ec2e
fix if
FrancoGiachetta Apr 8, 2025
7c15f64
Merge branch 'main' into avoid-reinstall-gmp
FrancoGiachetta Apr 9, 2025
33cddca
Merge branch 'main' into avoid-reinstall-gmp
FrancoGiachetta Apr 11, 2025
933f4fd
Merge branch 'main' into avoid-reinstall-gmp
gabrielbosio Apr 30, 2025
f07d3df
force gmp installation
FrancoGiachetta Sep 1, 2025
cc20948
merge main
FrancoGiachetta Sep 1, 2025
02a1d61
Merge branch 'main' into avoid-reinstall-gmp
FrancoGiachetta Sep 1, 2025
0375c23
Merge branch 'main' into avoid-reinstall-gmp
gabrielbosio Nov 13, 2025
77bd853
Merge branch 'main' into avoid-reinstall-gmp
gabrielbosio Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion install-scripts/install-macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@ source "$HOME/.cargo/env"
rustc --version

# Install pyenv
brew install pyenv gmp
brew install pyenv

# install gmp if it wasn't intalled before
if ! type foobar &> /dev/null; then
brew install gmp
fi
Copy link
Contributor

@JulianGCalderon JulianGCalderon Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is type foobar?

Copy link
Contributor

@JulianGCalderon JulianGCalderon Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can do:

brew install --force gmp

Instead of checking if it exists.

Copy link
Contributor Author

@FrancoGiachetta FrancoGiachetta Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in: f07d3df


# Make sure pyenv has been installed correctly
pyenv -v
Expand Down
Loading