Skip to content

Conversation

@igaray
Copy link
Collaborator

@igaray igaray commented Mar 19, 2025

Description

Removes the CODEOWNERS file as the requirement for codeowner reviews for merging has been temporarily lifted.

@github-actions
Copy link

github-actions bot commented Mar 19, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.369 s ±  0.001 s    [User: 25.594 s, System: 0.774 s]
  Range (min … max):   26.368 s … 26.370 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.352 s ±  0.064 s    [User: 25.588 s, System: 0.763 s]
  Range (min … max):   26.307 s … 26.397 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.712 s ±  0.069 s    [User: 25.753 s, System: 0.806 s]
  Range (min … max):   14.663 s … 14.760 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.685 s ±  0.017 s    [User: 25.686 s, System: 0.836 s]
  Range (min … max):   14.673 s … 14.696 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.350 s ±  0.095 s    [User: 38.240 s, System: 0.953 s]
  Range (min … max):   10.283 s … 10.417 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.491 s ±  0.251 s    [User: 37.764 s, System: 0.932 s]
  Range (min … max):   10.313 s … 10.669 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.01 ± 0.03 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.623 s ±  0.023 s    [User: 37.733 s, System: 0.945 s]
  Range (min … max):   10.607 s … 10.639 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.465 s ±  0.035 s    [User: 37.971 s, System: 1.028 s]
  Range (min … max):   10.441 s … 10.490 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.02 ± 0.00 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.444 s ±  0.159 s    [User: 38.193 s, System: 0.979 s]
  Range (min … max):   10.332 s … 10.557 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.566 s ±  0.301 s    [User: 38.282 s, System: 0.963 s]
  Range (min … max):   10.353 s … 10.779 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.03 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.406 s ±  0.149 s    [User: 38.617 s, System: 1.040 s]
  Range (min … max):   10.300 s … 10.511 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.320 s ±  0.270 s    [User: 38.560 s, System: 1.072 s]
  Range (min … max):   10.129 s … 10.511 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.01 ± 0.03 times faster than hyper_threading_main threads: 16


@github-actions
Copy link

github-actions bot commented Mar 19, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.115 ± 0.027 2.087 2.161 1.00 ± 0.01
head big_factorial 2.107 ± 0.012 2.097 2.136 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.074 ± 0.017 2.052 2.106 1.02 ± 0.01
head big_fibonacci 2.037 ± 0.017 2.020 2.065 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.663 ± 0.124 7.518 7.811 1.02 ± 0.02
head blake2s_integration_benchmark 7.516 ± 0.064 7.459 7.678 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.229 ± 0.036 2.201 2.324 1.02 ± 0.02
head compare_arrays_200000 2.181 ± 0.029 2.161 2.260 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.462 ± 0.009 1.453 1.483 1.02 ± 0.01
head dict_integration_benchmark 1.435 ± 0.010 1.424 1.459 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.217 ± 0.011 1.206 1.243 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.212 ± 0.005 1.204 1.221 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.630 ± 0.024 7.572 7.654 1.00
head integration_builtins 7.708 ± 0.451 7.525 8.986 1.01 ± 0.06
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.888 ± 0.037 7.853 7.976 1.01 ± 0.01
head keccak_integration_benchmark 7.830 ± 0.082 7.750 8.006 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.186 ± 0.028 2.150 2.234 1.02 ± 0.01
head linear_search 2.138 ± 0.008 2.123 2.151 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.545 ± 0.014 1.529 1.573 1.03 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.503 ± 0.008 1.490 1.513 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.481 ± 0.015 1.470 1.521 1.02 ± 0.01
head math_integration_benchmark 1.453 ± 0.015 1.443 1.493 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.235 ± 0.005 1.230 1.243 1.02 ± 0.00
head memory_integration_benchmark 1.209 ± 0.002 1.206 1.212 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.590 ± 0.016 1.572 1.621 1.02 ± 0.01
head operations_with_data_structures_benchmarks 1.565 ± 0.003 1.561 1.574 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 534.3 ± 2.9 530.5 540.3 1.01 ± 0.01
head pedersen 530.8 ± 2.7 528.0 536.1 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 632.0 ± 5.3 625.3 639.3 1.01 ± 0.01
head poseidon_integration_benchmark 624.4 ± 5.2 618.3 632.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.856 ± 0.008 1.845 1.870 1.01 ± 0.01
head secp_integration_benchmark 1.844 ± 0.010 1.833 1.863 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 630.0 ± 3.8 625.5 638.0 1.01 ± 0.01
head set_integration_benchmark 625.3 ± 2.6 622.5 630.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.228 ± 0.068 4.162 4.403 1.02 ± 0.02
head uint256_integration_benchmark 4.145 ± 0.019 4.119 4.182 1.00

@gabrielbosio gabrielbosio added the pipelines This PR/issue is exclusively about improving our CI label Mar 19, 2025
@FrancoGiachetta
Copy link
Contributor

The Run Lints job seems to be failing due to a program not being found. Perhaps we need to delete the cache and run the jobs again

@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (2723e6f) to head (bd923a6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2018   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files         102      102           
  Lines       42725    42725           
=======================================
  Hits        41245    41245           
  Misses       1480     1480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@igaray igaray merged commit 04e5e8d into main Mar 19, 2025
15 checks passed
@igaray igaray deleted the remove_codeowners branch March 19, 2025 16:39
gabrielbosio pushed a commit that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipelines This PR/issue is exclusively about improving our CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants