Refactor: Clap attribute macros from #[clap(...)] to #[arg(...)] and #[command(...)] in v4.x #2003
+37
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Himess
requested review from
Oppen,
fmoletta,
gabrielbosio,
igaray,
juanbono,
noaov1,
pefontana and
yuvalsw
as code owners
….)] to #[arg(...)] and #[command(...)] in v4.x
Contributor
Author
|
There were 4 errors in the GitHub workflow, one of which was the change in Changelog.md. This was required. I have now fixed it, and we can run the workflow again. |
Contributor
|
Hi @Himess! Thanks for the contribution. Don't worry for the remaining failing jobs, they won't succeed as they only run for internal contributors. |
FrancoGiachetta
approved these changes
Mar 18, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Merged
via the queue into
lambdaclass:main
with commit Mar 19, 2025
3aed532
181 of 184 checks passed
gabrielbosio
pushed a commit
that referenced
this pull request
May 21, 2025
…#[command(...)] in v4.x (#2003) * Update main.rs * Update main.rs * Update CHANGELOG.md to refactor: Clap attribute macros from #[clap(...)] to #[arg(...)] and #[command(...)] in v4.x --------- Co-authored-by: Julián González Calderón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates deprecated #[clap(...)] attributes to their modern equivalents in clap 4.x.
The current codebase still uses outdated syntax that has been deprecated since version 4.0.
By making this update, we ensure compatibility with future versions and maintain code quality.
Fixes #2002
Checklist