Skip to content

Conversation

@edg-l
Copy link
Contributor

@edg-l edg-l commented Mar 11, 2025

I think specifying the ref as head_ref tried to checkout the head using lambda repo instead of the author fork.

See https://github.com/lambdaclass/cairo-vm/actions/runs/13784962437/job/38554300107?pr=1988

@github-actions
Copy link

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.271 s ±  0.114 s    [User: 25.519 s, System: 0.749 s]
  Range (min … max):   26.191 s … 26.351 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.224 s ±  0.013 s    [User: 25.464 s, System: 0.758 s]
  Range (min … max):   26.215 s … 26.233 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.612 s ±  0.074 s    [User: 25.693 s, System: 0.788 s]
  Range (min … max):   14.559 s … 14.664 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.560 s ±  0.096 s    [User: 25.533 s, System: 0.760 s]
  Range (min … max):   14.492 s … 14.627 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.01 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.602 s ±  0.268 s    [User: 37.482 s, System: 0.925 s]
  Range (min … max):   10.412 s … 10.792 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.738 s ±  0.257 s    [User: 37.919 s, System: 0.883 s]
  Range (min … max):   10.556 s … 10.920 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.01 ± 0.04 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.254 s ±  0.058 s    [User: 38.442 s, System: 0.905 s]
  Range (min … max):   10.213 s … 10.295 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.676 s ±  0.106 s    [User: 37.950 s, System: 0.909 s]
  Range (min … max):   10.601 s … 10.751 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.04 ± 0.01 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.492 s ±  0.116 s    [User: 38.502 s, System: 0.938 s]
  Range (min … max):   10.410 s … 10.573 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.373 s ±  0.210 s    [User: 38.563 s, System: 0.963 s]
  Range (min … max):   10.225 s … 10.522 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.395 s ±  0.261 s    [User: 38.852 s, System: 1.036 s]
  Range (min … max):   10.211 s … 10.580 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.560 s ±  0.019 s    [User: 38.887 s, System: 1.097 s]
  Range (min … max):   10.547 s … 10.573 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.02 ± 0.03 times faster than hyper_threading_pr threads: 16


@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.150 ± 0.029 2.123 2.214 1.01 ± 0.02
head big_factorial 2.134 ± 0.017 2.119 2.174 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.074 ± 0.013 2.059 2.094 1.00 ± 0.01
head big_fibonacci 2.069 ± 0.021 2.052 2.122 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.809 ± 0.119 7.672 8.014 1.00
head blake2s_integration_benchmark 7.845 ± 0.115 7.718 8.084 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.198 ± 0.021 2.171 2.242 1.00
head compare_arrays_200000 2.201 ± 0.014 2.182 2.226 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.447 ± 0.049 1.421 1.583 1.01 ± 0.03
head dict_integration_benchmark 1.432 ± 0.005 1.426 1.440 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.229 ± 0.009 1.217 1.249 1.00
head field_arithmetic_get_square_benchmark 1.237 ± 0.016 1.225 1.263 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.820 ± 0.074 7.728 7.922 1.00 ± 0.01
head integration_builtins 7.799 ± 0.071 7.755 7.983 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.097 ± 0.092 8.000 8.255 1.00
head keccak_integration_benchmark 8.115 ± 0.091 8.021 8.308 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.185 ± 0.014 2.171 2.208 1.01 ± 0.01
head linear_search 2.174 ± 0.014 2.155 2.193 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.508 ± 0.007 1.500 1.519 1.00
head math_cmp_and_pow_integration_benchmark 1.520 ± 0.019 1.504 1.569 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.462 ± 0.004 1.457 1.468 1.00
head math_integration_benchmark 1.467 ± 0.006 1.460 1.477 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.227 ± 0.012 1.215 1.257 1.00 ± 0.01
head memory_integration_benchmark 1.224 ± 0.011 1.214 1.244 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.573 ± 0.013 1.558 1.599 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.573 ± 0.006 1.563 1.580 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 532.8 ± 1.9 530.2 535.0 1.00
head pedersen 533.4 ± 2.8 530.6 538.0 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 633.6 ± 3.4 630.3 642.3 1.00
head poseidon_integration_benchmark 635.0 ± 5.1 629.7 644.6 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.864 ± 0.011 1.847 1.882 1.00
head secp_integration_benchmark 1.882 ± 0.022 1.867 1.942 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 629.4 ± 2.5 626.6 634.6 1.00
head set_integration_benchmark 630.0 ± 2.2 627.3 633.1 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.297 ± 0.039 4.239 4.348 1.00
head uint256_integration_benchmark 4.309 ± 0.064 4.236 4.419 1.00 ± 0.02

@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (5c56712) to head (a06cc3f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1996   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files         103      103           
  Lines       42619    42619           
=======================================
  Hits        41142    41142           
  Misses       1477     1477           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@edg-l edg-l added the pipelines This PR/issue is exclusively about improving our CI label Mar 11, 2025
@gabrielbosio gabrielbosio added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit faa5e2d Mar 11, 2025
93 of 94 checks passed
@gabrielbosio gabrielbosio deleted the fix_hyper-thread-checkout branch March 11, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipelines This PR/issue is exclusively about improving our CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants