fix: bug in OS secp hint #1949
Closed
fix: bug in OS secp hint #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorimedini-starkware
requested review from
Oppen,
fmoletta,
gabrielbosio,
igaray,
juanbono and
pefontana
as code owners
Signed-off-by: Dori Medini <[email protected]>
dorimedini-starkware
force-pushed
the
dori/fix-bug-in-os-hint
branch
from
96c3dc0 to
7a2bdc6
Compare
Contributor
|
Hi @dorimedini-starkware! Our tests still look for the old hint, and fail when that hint is not found. |
Collaborator
Author
|
@JulianGCalderon is someone working on updating hints to 0.13.4? |
Collaborator
|
@dorimedini-starkware we have a PR that updates cairo-lang to 0.13.4. We were testing an alternative to this fix which is to add a new version of the hint instead of changing the last version of the hint. |
Collaborator
Author
|
ok, I'll close this one then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in OS SECP hint
Should be
PRIMEDescription of the pull request changes and motivation.
Checklist