Minor ret decoding refactor - #1925 cherry pick

[YairVaknin-starkware]

TITLE

Description

Description of the pull request changes and motivation.

Checklist

• Linked to Github Issue
• Unit tests added
• Integration tests added.
• This change requires new documentation.
  • Documentation has been added/updated.
  • CHANGELOG has been updated.

[github-actions]

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_factorial	2.493 ± 0.071	2.406	2.663	1.05 ± 0.05
head big_factorial	2.381 ± 0.081	2.284	2.520	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_fibonacci	2.549 ± 0.084	2.451	2.758	1.06 ± 0.05
head big_fibonacci	2.412 ± 0.068	2.275	2.532	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base blake2s_integration_benchmark	8.812 ± 0.110	8.625	9.001	1.04 ± 0.04
head blake2s_integration_benchmark	8.507 ± 0.299	8.261	9.310	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base compare_arrays_200000	2.634 ± 0.060	2.584	2.773	1.03 ± 0.04
head compare_arrays_200000	2.565 ± 0.079	2.480	2.692	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base dict_integration_benchmark	1.713 ± 0.038	1.661	1.794	1.05 ± 0.05
head dict_integration_benchmark	1.629 ± 0.060	1.581	1.793	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base field_arithmetic_get_square_benchmark	1.394 ± 0.022	1.364	1.424	1.03 ± 0.06
head field_arithmetic_get_square_benchmark	1.358 ± 0.072	1.299	1.552	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base integration_builtins	8.904 ± 0.156	8.758	9.281	1.04 ± 0.02
head integration_builtins	8.572 ± 0.125	8.426	8.879	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base keccak_integration_benchmark	9.238 ± 0.126	9.091	9.424	1.07 ± 0.05
head keccak_integration_benchmark	8.669 ± 0.389	8.262	9.641	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base linear_search	2.506 ± 0.064	2.448	2.640	1.04 ± 0.04
head linear_search	2.413 ± 0.065	2.346	2.576	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_cmp_and_pow_integration_benchmark	1.901 ± 0.051	1.832	2.017	1.07 ± 0.04
head math_cmp_and_pow_integration_benchmark	1.778 ± 0.048	1.715	1.880	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_integration_benchmark	1.722 ± 0.040	1.671	1.789	1.02 ± 0.04
head math_integration_benchmark	1.683 ± 0.062	1.595	1.839	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base memory_integration_benchmark	1.475 ± 0.042	1.429	1.550	1.04 ± 0.04
head memory_integration_benchmark	1.413 ± 0.029	1.375	1.462	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base operations_with_data_structures_benchmarks	1.827 ± 0.021	1.804	1.870	1.03 ± 0.02
head operations_with_data_structures_benchmarks	1.775 ± 0.030	1.727	1.825	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base pedersen	590.5 ± 10.0	571.4	605.1	1.01 ± 0.02
head pedersen	585.0 ± 9.4	564.3	597.2	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base poseidon_integration_benchmark	892.1 ± 15.5	854.4	905.7	1.06 ± 0.03
head poseidon_integration_benchmark	842.1 ± 15.3	812.4	869.3	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base secp_integration_benchmark	2.038 ± 0.042	1.993	2.119	1.02 ± 0.02
head secp_integration_benchmark	1.999 ± 0.024	1.948	2.042	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base set_integration_benchmark	740.8 ± 9.9	725.0	758.8	1.01 ± 0.02
head set_integration_benchmark	729.9 ± 11.9	714.4	749.7	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base uint256_integration_benchmark	4.964 ± 0.075	4.826	5.074	1.07 ± 0.03
head uint256_integration_benchmark	4.658 ± 0.106	4.537	4.800	1.00

[JulianGCalderon]

Hi @YairVaknin-starkware!

The job Test dependencies and cairo-vm install / Install on ubuntu-22.04 (pull_request) seems to be failing because it requires a newer rust version. Could you update it to 1.78 or newer? If you can't do it, let me know and i'll do it.

package cargo-platform v0.1.9 cannot be built because it requires rustc 1.78 or newer, while the currently active rustc version is 1.76.0

Unrelated to this, some test seems to be failing (don't know why yet). I'll be taking a look at it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.92%. Comparing base (93f1f54) to head (14a4fd9).
Report is 1 commits behind head on v1.0.2.

Additional details and impacted files

@@            Coverage Diff             @@
##           v1.0.2    #1930      +/-   ##
==========================================
+ Coverage   94.90%   94.92%   +0.02%     
==========================================
  Files         102      102              
  Lines       40288    40456     +168     
==========================================
+ Hits        38234    38403     +169     
+ Misses       2054     2053       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JulianGCalderon]

Turns out that the failing test was related to the cairo programs cache. Fixed it by cleaning the cache.

[YairVaknin-starkware]

Hi @YairVaknin-starkware!

The job Test dependencies and cairo-vm install / Install on ubuntu-22.04 (pull_request) seems to be failing because it requires a newer rust version. Could you update it to 1.78 or newer? If you can't do it, let me know and i'll do it.

package cargo-platform v0.1.9 cannot be built because it requires rustc 1.78 or newer, while the currently active rustc version is 1.76.0

Unrelated to this, some test seems to be failing (don't know why yet). I'll be taking a look at it.

Hi,
if you could do it, i'd really appreciate it. thanks!