Skip to content

Conversation

@tomasdema
Copy link
Contributor

TITLE

Description

Fixes a typo in the changelog.md

@github-actions
Copy link

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     32.333 s ±  0.820 s    [User: 31.597 s, System: 0.734 s]
  Range (min … max):   31.754 s … 32.913 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     32.387 s ±  0.019 s    [User: 31.664 s, System: 0.720 s]
  Range (min … max):   32.374 s … 32.400 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.03 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     17.775 s ±  0.131 s    [User: 31.026 s, System: 0.766 s]
  Range (min … max):   17.682 s … 17.867 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     18.132 s ±  0.103 s    [User: 31.586 s, System: 0.763 s]
  Range (min … max):   18.059 s … 18.205 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.02 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     12.462 s ±  0.429 s    [User: 44.293 s, System: 0.927 s]
  Range (min … max):   12.158 s … 12.765 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     12.479 s ±  0.388 s    [User: 43.971 s, System: 0.924 s]
  Range (min … max):   12.205 s … 12.754 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.00 ± 0.05 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     11.889 s ±  0.430 s    [User: 44.364 s, System: 0.939 s]
  Range (min … max):   11.585 s … 12.193 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     12.023 s ±  0.114 s    [User: 44.109 s, System: 0.971 s]
  Range (min … max):   11.943 s … 12.104 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.01 ± 0.04 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     11.899 s ±  0.009 s    [User: 44.388 s, System: 0.976 s]
  Range (min … max):   11.892 s … 11.905 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     11.980 s ±  0.169 s    [User: 44.345 s, System: 0.954 s]
  Range (min … max):   11.860 s … 12.100 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     12.033 s ±  0.327 s    [User: 44.427 s, System: 1.075 s]
  Range (min … max):   11.802 s … 12.265 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     11.666 s ±  0.120 s    [User: 44.665 s, System: 1.043 s]
  Range (min … max):   11.581 s … 11.750 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.03 ± 0.03 times faster than hyper_threading_main threads: 16


@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.579 ± 0.053 2.480 2.658 1.00
head big_factorial 2.584 ± 0.091 2.490 2.808 1.00 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.487 ± 0.090 2.410 2.704 1.00
head big_fibonacci 2.493 ± 0.039 2.423 2.555 1.00 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 9.326 ± 0.213 9.076 9.834 1.00
head blake2s_integration_benchmark 9.429 ± 0.347 9.194 10.400 1.01 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.618 ± 0.043 2.571 2.725 1.01 ± 0.02
head compare_arrays_200000 2.584 ± 0.036 2.543 2.647 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.717 ± 0.050 1.670 1.842 1.01 ± 0.04
head dict_integration_benchmark 1.703 ± 0.038 1.665 1.786 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.443 ± 0.015 1.416 1.470 1.00
head field_arithmetic_get_square_benchmark 1.463 ± 0.033 1.420 1.533 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.334 ± 0.103 9.186 9.510 1.01 ± 0.01
head integration_builtins 9.245 ± 0.081 9.095 9.364 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 9.672 ± 0.376 9.398 10.694 1.00
head keccak_integration_benchmark 9.691 ± 0.261 9.399 10.182 1.00 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.586 ± 0.031 2.541 2.633 1.00
head linear_search 2.633 ± 0.091 2.554 2.857 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.771 ± 0.034 1.727 1.830 1.01 ± 0.03
head math_cmp_and_pow_integration_benchmark 1.757 ± 0.042 1.712 1.823 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.709 ± 0.024 1.677 1.754 1.01 ± 0.02
head math_integration_benchmark 1.697 ± 0.014 1.669 1.714 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.444 ± 0.022 1.414 1.489 1.01 ± 0.03
head memory_integration_benchmark 1.430 ± 0.034 1.408 1.521 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.817 ± 0.028 1.792 1.875 1.00
head operations_with_data_structures_benchmarks 1.822 ± 0.035 1.787 1.891 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 589.6 ± 4.9 583.0 598.0 1.00
head pedersen 593.8 ± 8.4 582.4 612.9 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 705.6 ± 10.6 695.3 729.7 1.02 ± 0.02
head poseidon_integration_benchmark 694.0 ± 10.2 679.4 709.9 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.083 ± 0.027 2.058 2.129 1.00
head secp_integration_benchmark 2.088 ± 0.033 2.050 2.168 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 688.3 ± 14.4 678.4 726.5 1.01 ± 0.03
head set_integration_benchmark 684.1 ± 11.2 673.2 702.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 5.173 ± 0.207 5.019 5.707 1.01 ± 0.04
head uint256_integration_benchmark 5.109 ± 0.081 5.010 5.226 1.00

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (5af5924) to head (be988e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1929   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         102      102           
  Lines       40830    40830           
=======================================
  Hits        39336    39336           
  Misses       1494     1494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanbono juanbono added this pull request to the merge queue Jan 27, 2025
Copy link

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Merged via the queue into main with commit fb2b1fe Jan 27, 2025
91 checks passed
@juanbono juanbono deleted the typo-fix-in-changelog branch January 27, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants