Replace thiserror-no-std with thiserror 2 #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
Oppen,
fmoletta,
gabrielbosio,
igaray,
juanbono and
pefontana
as code owners
DaniPopes
force-pushed
the
thiserror-no-std
branch
from
0fbed94 to
961f926
Compare
Contributor
|
Hi @DaniPopes ! Thanks for the PR. Could you update the changelog? You can use this PR as an example: https://github.com/lambdaclass/cairo-vm/pull/1789/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed |
DaniPopes
force-pushed
the
thiserror-no-std
branch
from
961f926 to
b66f7c2
Compare
Contributor
Author
|
Done |
edg-l
approved these changes
Mar 10, 2025
JulianGCalderon
approved these changes
Mar 10, 2025
gabrielbosio
approved these changes
Mar 17, 2025
Merged
via the queue into
lambdaclass:main
with commit Mar 17, 2025
f1909dd
181 of 184 checks passed
gabrielbosio
added a commit
that referenced
this pull request
May 21, 2025
* Replace thiserror-no-std with thiserror 2 * Fix fuzzer using old thiserror-no-std --------- Co-authored-by: Edgar <[email protected]> Co-authored-by: Edgar Luque <[email protected]> Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update thiserror to v2, which includes no_std support.