Missing dynamic layout features #1838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-sw-fix-version
…or-sw-fix-version
The same value is used in python-vm
JulianGCalderon
force-pushed
the
dynamic-layout-2
branch
from
4c90ff4 to
6395615
Compare
JulianGCalderon
force-pushed
the
dynamic-layout-2
branch
2 times, most recently
from
b0242c4 to
515063a
Compare
JulianGCalderon
force-pushed
the
dynamic-layout-2
branch
from
515063a to
5d2d263
Compare
JulianGCalderon
requested review from
Oppen,
fmoletta,
igaray,
juanbono and
pefontana
as code owners
pefontana
reviewed
Oct 2, 2024
pefontana
reviewed
Oct 2, 2024
Collaborator
pefontana
left a comment
pefontana
left a comment
There was a problem hiding this comment.
Nice one @JulianGCalderon !!!
Also, can you add a little documentation in the readme explaining how to use the dynamic layout
pefontana
approved these changes
Oct 2, 2024
pefontana
approved these changes
Oct 2, 2024
igaray
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing dynamic layout features
Solves #1834
Features
memory units per step. This attributes used to be a fixed constantMEMORY_UNITS_PER_STEP. This PR changes this to use aCairoLayoutattribute insteadlog diluted units per step. I added an attribute toDilutedPoolInstanceDefthat indicates iflog_units_per_stepis negative or positive.ratio den. Builtins that can have a low ratio now use theLowRatiostruct, which has a denominator and a numerator.cpu component step. Currently not usedChecklist