Don't validate memory values #1783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alon-Ti
requested review from
Oppen,
fmoletta,
igaray,
juanbono and
pefontana
as code owners
Alon-Ti
force-pushed
the
dont-validate-addresses
branch
from
cb38b3c to
fb435b1
Compare
juanbono
requested changes
Jun 5, 2024
Collaborator
juanbono
left a comment
juanbono
left a comment
There was a problem hiding this comment.
Can you add some tests to this?
Contributor
Author
Alon-Ti
force-pushed
the
dont-validate-addresses
branch
from
fb435b1 to
62ed419
Compare
Contributor
Author
|
@juanbono I amended an existing test to cover this, will add a test CairoPie with all the edge cases once I'm sure all our test CairoPies run. |
fmoletta
reviewed
Jun 10, 2024
Alon-Ti
force-pushed
the
dont-validate-addresses
branch
from
62ed419 to
94df9f9
Compare
Alon-Ti
force-pushed
the
dont-validate-addresses
branch
from
94df9f9 to
b600ba3
Compare
Oppen
approved these changes
Jun 15, 2024
juanbono
approved these changes
Jun 19, 2024
fmoletta
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove validation of values in CairoPie Memory.