feat: load Cairo PIE from bytes #1773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
requested review from
Oppen,
fmoletta,
igaray,
juanbono and
pefontana
as code owners
fmoletta
approved these changes
May 23, 2024
juanbono
approved these changes
May 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Context: bootloader support. Like for programs, it is convenient to be able to load Cairo PIEs directly from bytes. Added a `from_bytes()` method to `CairoPie`. This method shares most of its code with `read_from_file()`.
odesenfans
force-pushed
the
msl/read-cairo-pie-from-bytes
branch
from
a804269 to
a1befc3
Compare
Oppen
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: bootloader support.
Like for programs, it is convenient to be able to load Cairo PIEs directly from bytes. Added a
from_bytes()method toCairoPie. This method shares most of its code withread_from_file().TITLE
Description
Description of the pull request changes and motivation.
Checklist