Skip to content

fix: make MemorySegmentManager.finalize() public #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2024
Merged

fix: make MemorySegmentManager.finalize() public #1771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fd0e5c
fix: make MemorySegmentsManager.finalize() public
odesenfans May 22, 2024
5e8b9d4
changelog
odesenfans May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#### Upcoming Changes

* fix: make MemorySegmentManager.finalize() public [#1771](https://github.com/lambdaclass/cairo-vm/pull/1771)

* feat(BREAKING): Serialize `Array<Felt252>` return value into output segment in cairo1-run crate:
* Checks that only `PanicResult<Array<Felt252>>` or `Array<Felt252>` can be returned by the program when running with either `--proof_mode` or `--append_return_values`.
* Serializes return values into the output segment under the previous conditions following the format:
Expand Down
2 changes: 1 addition & 1 deletion vm/src/vm/vm_memory/memory_segments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ impl MemorySegmentManager {
// * size - The size of the segment (to be used in relocate_segments).
// * public_memory - A list of offsets for memory cells that will be considered as public
// memory.
pub(crate) fn finalize(
pub fn finalize(
&mut self,
size: Option<usize>,
segment_index: usize,
Expand Down