Skip to content

fix to_signed_felt doc #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
greged93 wants to merge 3 commits into from
Closed

fix to_signed_felt doc #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fb038c
fix to_signed_felt doc
greged93 Jun 19, 2023
190d0df
fix deps doc
greged93 Jun 19, 2023
7abe5a0
Merge branch 'main' into fix/doc
MegaRedHand Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/parse-hyperlinks/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use nom::IResult;
/// ```
/// use nom::bytes::complete::tag;
/// use nom::sequence::delimited;
/// use parse_hyperlinks::take_until_unbalanced;
/// use cairo_take_until_unbalanced::take_until_unbalanced;
///
/// let mut parser = delimited(tag("<"), take_until_unbalanced('<', '>'), tag(">"));
/// assert_eq!(parser("<<inside>inside>abc"), Ok(("abc", "<inside>inside")));
Expand Down
4 changes: 2 additions & 2 deletions felt/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ pub(crate) trait FeltOps {
/// # use num_bigint::BigInt;
/// # use num_traits::Bounded;
/// let positive = Felt252::new(5);
/// assert_eq!(positive.to_bigint(), Into::<num_bigint::BigInt>::into(5));
/// assert_eq!(positive.to_signed_felt(), Into::<num_bigint::BigInt>::into(5));
///
/// let negative = Felt252::max_value();
/// assert_eq!(negative.to_bigint(), Into::<num_bigint::BigInt>::into(-1));
/// assert_eq!(negative.to_signed_felt(), Into::<num_bigint::BigInt>::into(-1));
/// ```
fn to_signed_felt(&self) -> BigInt;

Expand Down