-
Notifications
You must be signed in to change notification settings - Fork 210
Add ensure_no_std build to CI
#1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0e2df78
Add ensure_no_std build to CI
MegaRedHand c10ecb0
Add print to test
MegaRedHand 2d2ded8
Install wasm32 target for no-std testing
MegaRedHand 67f1767
Fix: added option in wrong job
MegaRedHand 88ca921
Try another breaking change
MegaRedHand eb9589b
Remove "alloc" feature in Cargo.toml
MegaRedHand 60cd94d
Also add compilation with the 'alloc' option
MegaRedHand b935ddf
Add cairo-vm to ensure_no_std deps
MegaRedHand 97ebba2
Remove alloc feature
MegaRedHand 7ba3063
Fix (WIP)
MegaRedHand 1f8939d
comment vm (not no_std ready); use nightly toolchain
7da2312
add Timothée num-prime fork and fix no-std support
0df698a
run cargo fmt
63fbd26
fix clippy; add original num_prime for tests; ignore unused FloatCore
763b766
fix typo on unused_variables instead imports
b18db22
remove prime computations for non default primality test config
6629e4f
Merge branch 'main' into add-ensure_no_std-to-CI
MegaRedHand d7a8262
Split implementation of is_prime into std/no_std
MegaRedHand 3d627ec
Remove unused import
MegaRedHand bbcf0c4
Change some constants
MegaRedHand 0f03d99
Update dir name
MegaRedHand b2148ba
Fix errors
MegaRedHand 1451c77
Use modpow, and increase time of bench
MegaRedHand a732598
Merge smoke and smoke-no_std
MegaRedHand c08a4b8
Use mul instead of pow
MegaRedHand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,7 +63,7 @@ jobs: | |
| name: Run Lints | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Install Rust 1.69.0 | ||
| - name: Install Rust | ||
| uses: dtolnay/[email protected] | ||
| with: | ||
| components: rustfmt, clippy | ||
|
|
@@ -114,7 +114,7 @@ jobs: | |
| name: Make sure all builds work | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Install Rust 1.69.0 | ||
| - name: Install Rust | ||
| uses: dtolnay/[email protected] | ||
| - name: Set up cargo cache | ||
| uses: Swatinem/rust-cache@v2 | ||
|
|
@@ -158,6 +158,27 @@ jobs: | |
| run: cargo check-all-features --workspace --all-targets | ||
|
|
||
|
|
||
| # NOTE: the term "smoke test" comes from electronics design: the minimal | ||
| # expectations anyone has in their device is to not catch fire on boot. | ||
| smoke-no-std: | ||
| name: Make sure no-std works | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Install Rust | ||
| uses: dtolnay/[email protected] | ||
| with: | ||
| targets: wasm32-unknown-unknown | ||
| - name: Set up cargo cache | ||
| uses: Swatinem/rust-cache@v2 | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Check | ||
| run: | | ||
| cd ensure_no_std | ||
| cargo build --release | ||
| cargo build --release -F alloc | ||
|
|
||
| tests: | ||
| needs: build-programs | ||
| strategy: | ||
|
|
@@ -168,7 +189,7 @@ jobs: | |
| name: Run tests | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Install Rust 1.69.0 | ||
| - name: Install Rust | ||
| uses: dtolnay/[email protected] | ||
| with: | ||
| components: llvm-tools-preview | ||
|
|
@@ -237,7 +258,7 @@ jobs: | |
| name: Build release binary for comparisons | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Install Rust 1.69.0 | ||
| - name: Install Rust | ||
| uses: dtolnay/[email protected] | ||
| - name: Set up cargo cache | ||
| uses: Swatinem/rust-cache@v2 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.