Skip to content

Conversation

@MegaRedHand
Copy link
Contributor

@MegaRedHand MegaRedHand commented Apr 25, 2023

Depends on: #1026

Description

This PR adds the missing hint NewHint#19, now known as EC_DOUBLE_SLOPE_EXTERNAL_CONSTS.

@MegaRedHand MegaRedHand added the whitelisted-hint Implementation of hint on whitelist directory label Apr 25, 2023
@MegaRedHand MegaRedHand self-assigned this Apr 25, 2023
@MegaRedHand MegaRedHand marked this pull request as draft April 25, 2023 22:07
@github-actions
Copy link

github-actions bot commented Apr 25, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 3.165 ± 0.070 3.026 3.299 1.02 ± 0.03
head blake2s_integration_benchmark 3.116 ± 0.066 3.044 3.276 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.827 ± 0.068 3.735 3.943 1.01 ± 0.02
head compare_arrays_200000 3.775 ± 0.042 3.720 3.860 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.868 ± 0.031 2.831 2.919 1.01 ± 0.03
head dict_integration_benchmark 2.838 ± 0.079 2.734 3.000 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.591 ± 0.096 4.445 4.766 1.02 ± 0.02
head factorial_multirun 4.519 ± 0.052 4.444 4.608 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.652 ± 0.036 3.590 3.713 1.01 ± 0.03
head fibonacci_1000_multirun 3.614 ± 0.092 3.505 3.829 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 144.5 ± 5.1 139.9 158.0 1.01 ± 0.08
head field_arithmetic_get_square_benchmark 142.9 ± 10.5 133.1 168.7 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 3.558 ± 0.074 3.460 3.690 1.00 ± 0.03
head integration_builtins 3.544 ± 0.066 3.474 3.661 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 3.334 ± 0.085 3.258 3.538 1.00
head keccak_integration_benchmark 3.354 ± 0.028 3.304 3.400 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.906 ± 0.050 3.839 3.986 1.02 ± 0.02
head linear_search 3.846 ± 0.076 3.790 4.006 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.288 ± 0.046 3.216 3.349 1.04 ± 0.02
head math_cmp_and_pow_integration_benchmark 3.173 ± 0.028 3.143 3.238 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.893 ± 0.046 2.832 2.991 1.00
head math_integration_benchmark 2.920 ± 0.054 2.882 3.021 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.565 ± 0.045 2.517 2.672 1.00
head memory_integration_benchmark 2.582 ± 0.034 2.530 2.646 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.590 ± 0.034 2.534 2.669 1.00
head operations_with_data_structures_benchmarks 2.596 ± 0.054 2.533 2.699 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 881.5 ± 13.5 867.6 914.1 1.01 ± 0.02
head pedersen 873.5 ± 12.8 855.1 892.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.630 ± 0.034 1.602 1.713 1.00 ± 0.03
head poseidon_integration_benchmark 1.627 ± 0.026 1.589 1.672 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.888 ± 0.028 2.848 2.939 1.00
head secp_integration_benchmark 2.888 ± 0.060 2.828 3.045 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.016 ± 0.020 1.988 2.048 1.00
head set_integration_benchmark 2.049 ± 0.030 2.013 2.110 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.497 ± 0.113 4.329 4.667 1.01 ± 0.03
head uint256_integration_benchmark 4.438 ± 0.074 4.350 4.525 1.00

@MegaRedHand MegaRedHand marked this pull request as ready for review April 26, 2023 14:18
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #1057 (e5658d4) into main (45a43aa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files          84       84           
  Lines       33867    33926   +59     
=======================================
+ Hits        33222    33281   +59     
  Misses        645      645           
Impacted Files Coverage Δ
...rocessor/builtin_hint_processor/secp/secp_utils.rs 100.00% <ø> (ø)
src/utils.rs 99.43% <ø> (ø)
...int_processor/builtin_hint_processor_definition.rs 99.00% <100.00%> (+<0.01%) ⬆️
..._processor/builtin_hint_processor/secp/ec_utils.rs 99.54% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from newhint17-newhint18-imports to main April 26, 2023 23:34
@Oppen Oppen enabled auto-merge April 27, 2023 01:10
@MegaRedHand MegaRedHand force-pushed the newhint19-double_slope_external_consts branch from f314977 to 85ab196 Compare April 27, 2023 13:30
@MegaRedHand
Copy link
Contributor Author

Rebased onto main after merge of #1026

@Oppen Oppen added this pull request to the merge queue Apr 27, 2023
Merged via the queue into main with commit 0fad948 Apr 27, 2023
@Oppen Oppen deleted the newhint19-double_slope_external_consts branch April 27, 2023 14:12
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Add NewHint#19

* Update changelog

* Allow trailing commas in check_scope macro

* Fix: was trying to get BigUint from exec_scopes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

whitelisted-hint Implementation of hint on whitelist directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants