-
Notifications
You must be signed in to change notification settings - Fork 211
perf: verified addresses for Pedersen as Vec<bool> #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1029 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 79 79
Lines 32694 32703 +9
=======================================
+ Hits 32069 32078 +9
Misses 625 625
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The use of a `Vec<Relocatable>` was the major bottleneck for that builtin.
juanbono
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MegaRedHand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
The use of a `Vec<Relocatable>` was the major bottleneck for that builtin.
The use of a
Vec<Relocatable>was the major bottleneck for that builtin.Checklist