Skip to content

Conversation

@MegaRedHand
Copy link
Contributor

Description

This PR adds the missing hint NewHint#14, now known as HI_MAX_BITLEN.

@github-actions
Copy link

github-actions bot commented Apr 18, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 3.698 ± 0.101 3.563 3.850 1.03 ± 0.03
head blake2s_integration_benchmark 3.593 ± 0.059 3.513 3.684 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.465 ± 0.143 4.251 4.633 1.04 ± 0.04
head compare_arrays_200000 4.284 ± 0.109 4.152 4.436 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.459 ± 0.046 3.395 3.524 1.06 ± 0.03
head dict_integration_benchmark 3.271 ± 0.075 3.144 3.379 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 5.479 ± 0.119 5.259 5.625 1.03 ± 0.02
head factorial_multirun 5.305 ± 0.047 5.247 5.394 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.405 ± 0.074 4.315 4.572 1.04 ± 0.03
head fibonacci_1000_multirun 4.246 ± 0.105 4.038 4.409 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 4.380 ± 0.108 4.257 4.586 1.05 ± 0.03
head integration_builtins 4.187 ± 0.088 4.081 4.335 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 4.017 ± 0.057 3.941 4.110 1.02 ± 0.02
head keccak_integration_benchmark 3.951 ± 0.066 3.815 4.017 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.451 ± 0.118 4.302 4.600 1.03 ± 0.04
head linear_search 4.326 ± 0.118 4.121 4.531 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.592 ± 0.060 3.531 3.703 1.00
head math_cmp_and_pow_integration_benchmark 3.672 ± 0.045 3.564 3.717 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.460 ± 0.046 3.383 3.499 1.03 ± 0.02
head math_integration_benchmark 3.365 ± 0.063 3.293 3.479 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 3.136 ± 0.093 3.067 3.378 1.04 ± 0.03
head memory_integration_benchmark 3.021 ± 0.022 2.972 3.049 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 3.046 ± 0.056 2.993 3.193 1.04 ± 0.02
head operations_with_data_structures_benchmarks 2.935 ± 0.031 2.873 2.981 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 4.260 ± 0.068 4.185 4.429 1.01 ± 0.02
head pedersen 4.207 ± 0.025 4.164 4.246 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.916 ± 0.017 1.889 1.939 1.03 ± 0.03
head poseidon_integration_benchmark 1.860 ± 0.048 1.786 1.926 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.360 ± 0.072 3.229 3.470 1.00
head secp_integration_benchmark 3.444 ± 0.043 3.368 3.494 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.495 ± 0.101 2.405 2.765 1.00
head set_integration_benchmark 2.522 ± 0.060 2.473 2.671 1.01 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 5.103 ± 0.102 4.937 5.269 1.04 ± 0.03
head uint256_integration_benchmark 4.887 ± 0.105 4.674 5.036 1.00

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1008 (dfe233e) into main (d307312) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1008   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          76       76           
  Lines       31729    31767   +38     
=======================================
+ Hits        31105    31143   +38     
  Misses        624      624           
Impacted Files Coverage Δ
...int_processor/builtin_hint_processor_definition.rs 98.80% <100.00%> (+<0.01%) ⬆️
...cessor/builtin_hint_processor/secp/bigint_utils.rs 98.51% <100.00%> (+0.32%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MegaRedHand MegaRedHand added the whitelisted-hint Implementation of hint on whitelist directory label Apr 18, 2023
@MegaRedHand MegaRedHand enabled auto-merge April 19, 2023 19:13
@MegaRedHand MegaRedHand added this pull request to the merge queue Apr 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 19, 2023
@MegaRedHand MegaRedHand enabled auto-merge April 19, 2023 20:13
@MegaRedHand MegaRedHand added this pull request to the merge queue Apr 19, 2023
Merged via the queue into main with commit 56828e1 Apr 19, 2023
@MegaRedHand MegaRedHand deleted the newhint14-hi_max_len branch April 19, 2023 21:04
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Add NewHint#14

* Update changelog

* Change assert_matches for assert + is_ok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

whitelisted-hint Implementation of hint on whitelist directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants