-
Notifications
You must be signed in to change notification settings - Fork 210
feat(hints): add NewHint#13 #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4612fe7 to
9a99ea6
Compare
9a99ea6 to
b93268e
Compare
|
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1006 +/- ##
=======================================
Coverage 98.02% 98.03%
=======================================
Files 76 76
Lines 31667 31729 +62
=======================================
+ Hits 31043 31105 +62
Misses 624 624
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I wanted to add this since someone mentioned it in the Hacker House at Tel Aviv, but couldn't remember the name of the trick to find it online. |
Oppen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Feels dirty! Co-authored-by: Mario Rugiero <[email protected]>
* Add NewHint#13 * Update changelog * Add test for when m is too high * Restrict the guard clause in quad_bit * Simplify match with unwrap_or Feels dirty! Co-authored-by: Mario Rugiero <[email protected]> * Fix build errors --------- Co-authored-by: Mario Rugiero <[email protected]>
Description
This PR adds the missing hint NewHint#13, now known as
QUAD_BIT. I placed the implementation in thesecp::ec_utilsmodule because it's used in point multiplication via Shamir's trick + Windowed method.