feat: Implement hints on field_arithmetic lib (Part 2) #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
requested review from
Juan-M-V,
entropidelic,
igaray,
juanbono and
pefontana
as code owners
Oppen
approved these changes
Apr 21, 2023
Contributor
Oppen
left a comment
Oppen
left a comment
There was a problem hiding this comment.
LGTM. There are a few comments but they are non-blocking. Please address them if something else comes up, otherwise feel free to ignore them.
Co-authored-by: Mario Rugiero <[email protected]>
fmoletta
added
the
whitelisted-hint
juanbono
approved these changes
Apr 21, 2023
…ro-rs into field-arithmetic-hints-2
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
) * Add hint code for UINT348_UNSIGNED_DIV_REM * Add file for uint348 files * Add pack & split for uint348 * Move comment * Implement uint348_unsigned_div_rem hint * Add integration test * Add integration test * Add unit tests * Add hint on split_128 * Test split_128 hint * Add add_no_uint384_hint * Fix hint + add tests * Add hint code for UINT348_UNSIGNED_DIV_REM_EXPAND * Msc fixes * Add integration test * Reduce Uint384_expand representation to the 3 used limbs * Add unit test * Add hint code for UINT384_SQRT * Add implementation for hint on sqrt * Integration test * Add unit tests * Fix missing directive * Run cairo-format * Add changelog entry * Spelling * Add hint code + Uint768 type * Implement hint unsigned_div_rem_uint768_by_uint384 * Update src/hint_processor/builtin_hint_processor/uint384.rs Co-authored-by: Mario Rugiero <[email protected]> * Update src/hint_processor/builtin_hint_processor/uint384.rs Co-authored-by: Mario Rugiero <[email protected]> * Update src/hint_processor/builtin_hint_processor/uint384.rs Co-authored-by: Mario Rugiero <[email protected]> * Make hint code more readable * Add integration test * Add test * Add unit test * Add changelog entry + fmt * Fix plural * cargo fmt * Add first draft of get_square_root * Fix test * Fix syntax * Fix test * Add necessary lib fns * fix fmt * Fix test value * Add test program * Add hint to execute_hint * Fix wrong hint being tested * Implement sqrt * Add test fix file * Fix _sqrt_mod_tonelli_shanks implementation * Expand integration test * Add unit test * Add proptests * Fix merge conflict * Fix merge conflict * Add changelog entry * Use no-std compatible rng when std is not enabled * Clippy * Use seeded rng instead of from_entropy * Catch potential zero divison errors * Implement hint on div * Expand field_arithmetic integration test * Expand field_arithmetic integration test * Add test + fix hint * Fix merge conflict * Use mul_inv instead of div_mod * Add Changelog entry * Add unit tests * remove unused feature * Fix test value * Update cairo_programs/field_arithmetic.cairo Co-authored-by: Mario Rugiero <[email protected]> * Increase number of memory holes for field_arithmetic test --------- Co-authored-by: Mario Rugiero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #985
Description
Description of the pull request changes and motivation.
Checklist