Mouse bindings #379
Merged
Mouse bindings #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
do mouse side buttons work? |
Contributor
Author
yes, any mouse button except for right/left click. |
Human-readable mouse names start with 1. Using this scheme aligns with what you'd see in RusherHack for example. To accomplish this, any raw mouse input that comes as an index we simply increment by 1. I'm planning on PR'ing a hud module that shows all bindings, again like in Rusherhack. So this would trigger my OCD having those bind names not align between clients.
also mousekey is concurrent and may change after first null check.
Avanatiker
approved these changes
Sep 30, 2022
Member
|
Thank you a lot for your fist contribution! Let me know your discord so i can give you the contributor role :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
Add mouse key bindings for module toggle states. Bindings are limited to buttons that are not left or right click.
Describe how this pull is helpful
Mouse key bindings allow users to toggle modules without using their keyboard if they have a mouse with additional buttons.
Additional context
Existing or added bindings for keyboard bindings are not affected by this and are still allowed.