Ignore trailing commas in ExpectedDebug
#455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-lang/rust/pull/59076 changed the multiline Debug representation to always include a trailing comma. This change currently breaks our tests on beta and nightly, since we use this Debug representation to compare expected parsing output. We cannot simply add the trailing commas to the expected output strings, since that would break on older rustc versions we support. Instead, this commit makes it so that all trailing commas are stripped before the comparison. This workaround can be removed once rust-lang/rust/pull/59076 reaches our minimum supported rustc version.
That's required by the current version rustc-demangle, which is a dependency of mdbook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust/pull/59076 changed the multiline Debug representation to
always include a trailing comma. This change currently breaks our tests
on beta and nightly, since we use this Debug representation to compare
expected parsing output.
We cannot simply add the trailing commas to the expected output strings,
since that would break on older rustc versions we support. Instead, this
commit makes it so that all trailing commas are stripped before the
comparison.
This workaround can be removed once rust-lang/rust/pull/59076 reaches
our minimum supported rustc version.