-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: session reconnect / clone #11
Comments
Thanks @lalbornoz for the quick action on both the CVE and the feature request! The session clone seems to work; session reconnect not quite yet: a username/password is still requested upon reconnect. Not sure whether you were intending to have this functionality in the new release. |
Oh hey, you caught me right while I was rather sick w/ COVID or some such, totally forgot about you after the CVE fix from upstream, sorry about that. I'm kinda busy w/ other stuff right now but I'll get back to this as soon as possible, this shouldn't take much to implement. Session clone was already there, though w/o caching credentials across sessions, which I'm assuming is what's sought after here. |
Correct assumption - thanks! |
Initial implementation is in PuTTie-file-Release-4fe80e3f and PuTTie-registry-Release-4fe80e3f, can you confirm that this works as intended? |
Thanks! I tested this by connecting to a server, disconnecting from WiFi, waiting for timeout ( |
Did you [x] Cache passwords in Frippery -> General pointless frippery beforehand? This is disabled by default. |
Thanks for the pointer, I did not 😄 Further testing:
Keep up the good work! 🚀 |
I'm not sure I follow here. When I start PuTTie, [x] Cache passwords in Frippery, then connect somewhere, login w/ a password, then restart that same session or duplicate it, the password is cached as expected. Is this not the case for you? |
Sorry, messed up editing your comment instead of mine. Looking into this now. |
No worries. To be clear: with saved sessions this functionality does work. One optimization point might be the use of simply pressing to reconnect per the above comment. |
When you start an 'on the fly' session w/ [x] Cache passwords, is it just asking for the username or for both the username and the password? |
Both username and password are asked for. |
Well, I can't reproduce this at all. I'll try later on Windows, though I doubt that this is a wine vs. Windows issue. |
Odd. Just tried once more, doesn't work. Is there anything I can do to help debug? |
I'll prepare a debug build for you today or tomorrow. |
Can you do the same thing you did before w/ this debug build: https://www.luciaillanes.de/assets/putty-debug-cachepassword.zip and provide me with the debug console log after having done so? |
Sure! Attached the logs of both debug windows (first the one when starting PuTTie, then the one when attempting 'Duplicate Session'). I've removed some personal data from the logs (xxx/yyy) and from the screenshot (red). |
Thanks! However, you've not proceeded to entering your username in the duplicated session, so the debug log didn't get to the part where the cached password would've (or not) been sent. Could you repeat the above process and also provide your username in the duplicated sesson and upload the debug log again? |
And not sure if this intentional: in the debug build, when saving the session, |
When providing the username, I'm able to login without password. The log goes attached. |
This feature solely implements caching passwords, not usernames. You can configure a username to automatically login w/ with Connection -> Data -> Login details -> Auto-login username. |
Session reconnect on disconnect will be implemented in a separate commit/release. |
I'm using 7604753 and have "Automatically restart session on disconnect" checked but it doesn't seem to do anything after disconnected? The window just hangs (in the sense it does nothing). The event log looks like this:
Also I can't find the "Restart session" in the menu nor an option to enable that. |
Hi there, thanks for going through the rabbit hole of forking PuTTY and keeping up with releases!
I'm a KiTTY user for years, but unfortunately it's not very actively developed any longer as for each new PuTTY release, one needs to start (almost) from scratch. In your intro I read PuTTie differs from this, so there's hope :-)
One of the most used KiTTY features not available in PuTTie is session reconnect and session clone. It allows to press to reconnect using the same credentials, after e.g. returning from standby or after network disconnect.
Is this something that may be added in future releases?
Also, I wanted to point out 'CVE-2024-31497: Secret Key Recovery of NIST P-521 Private Keys Through Biased ECDSA Nonces in PuTTY Client'. Assuming PuTTie is also impacted, this is something that deserves some attention.
Thanks again!
The text was updated successfully, but these errors were encountered: