Use 'aa-complain' instead of 'complain' to remove dnsmasq restriction #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, This also needs to be compatible with |
Thanks for the response; I've made some changes to check for both. |
|
Thanks. I think you missed the $. I fixed it. |
|
@lakinduakash when will this be merged and released in the build? |
ByteSnipers
added a commit
to ByteSnipers/linux-router
that referenced
this pull request
Dec 18, 2024
added support for aa-complian. The issue was already fixed in linux-wifi-hotspot project. lakinduakash/linux-wifi-hotspot#314 --------------------- Issue: complain was not found on my system and the script could not be executed. Below is the error output. Starting dnsmasq dnsmasq: cannot read /dev/shm/lnxrouter_tmp/lnxrouter.wlp0s20f0u7.conf.U5zWYP/dnsmasq.conf: Permission denied Error occured ERROR: Couldn't get dnsmasq PID Error occured Doing cleanup.. Killed haveged_watchdog.pid 216223 lnxrouter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the default installation from the AUR, I ran into the following error when trying to create a hotspot:
dnsmasq: cannot read /tmp/create_ap.wlp18s0.conf.fgQTo8iD/dnsmasq.conf: Permission deniedThis looks like it's related related to an old issue with create_ap discussed here, where @mehdisadeghi has found a solution, although it seems it hasn't been implemented.
Seems like
complainis being used to remove restrictions on dmsmasq, although the command is supposed to beaa-complain. At least, this has been the case when testing on my system (Manjaro) as well as on Arch according to that thread.From the OpenSUSE docs, it looks like aa-complain is the correct command on OpenSUSE distros as well, so I think it makes sense to make this change: https://doc.opensuse.org/documentation/leap/security/html/book-security/cha-apparmor-commandline.html
I imagine this requires a bit more testing though.