-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test DataFusion 45.0.0 with Sail #365
Merged
Merged
+489
−336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Loading status checks…
Gold Data ReportNotes
Commit Information
Summary
DetailsGold Data Metrics
|
This was referenced Feb 2, 2025
Spark Test ReportCommit Information
Test Summary
Test DetailsError Counts
Passed Tests Diff(empty) |
linhr
approved these changes
Feb 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
linhr
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 1: Commit
68e372f
(DataFusionmain
)1. Derived TPC-DS Query 66 fails on Sail, when it previously did not.
2. Another regression is that implementing the
is_nullable
function in theScalarUDFImpl
trait no longer works. For example:Test 2: Commit
26058ac
(DataFusion45.0.0-rc1
)1. Derived TPC-DS Query 66 still failing, with same error.
2. Same issue still. I ended up removing
is_nullable
and implementingreturn_type_from_args
. This seems to be a breaking change rather thanis_nullable
simply being deprecated.