fix: remove unreachable datafusion SQL methods from clippy.toml#1626
Merged
Conversation
Agent-Logs-Url: https://github.com/lakehq/sail/sessions/99c6ec6e-0b0d-4864-9468-9a1ac27598a3 Co-authored-by: lonless9 <167735979+lonless9@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
lonless9
April 8, 2026 13:24
View session
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1626 +/- ##
==========================================
- Coverage 75.61% 75.61% -0.01%
==========================================
Files 880 880
Lines 118699 118699
==========================================
- Hits 89755 89753 -2
- Misses 28944 28946 +2
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
linhr
approved these changes
Apr 9, 2026
lonless9
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As a follow-up of #1437, which removed the datafusion
sqlfeature, 10 entries inclippy.toml'sdisallowed-methodslist reference SQL-related datafusion methods that are no longer reachable. This causes clippy to emit 10 warnings like:This PR removes those 10 unreachable entries from
clippy.toml.Changes
Removed the following entries from
disallowed-methodsinclippy.toml(they are part of thesqlfeature that was disabled):SessionContext::parse_sql_exprSessionContext::sqlSessionContext::sql_with_optionsSessionState::create_logical_exprSessionState::create_logical_planSessionState::resolve_table_referencesSessionState::sql_to_exprSessionState::sql_to_expr_with_aliasSessionState::sql_to_statementSessionState::statement_to_planFixes: https://github.com/lakehq/sail/actions/runs/24136921480/job/70427432354