Conversation
41 tasks
Gold Data ReportNotes
Commit Information
Summary
DetailsGold Data Metrics
|
lonless9
commented
Jan 7, 2026
Comment on lines
+175
to
+179
| if let Some(lfc) = ctx.runtime_env().cache_manager.get_list_files_cache() { | ||
| for table_path in &table_paths { | ||
| let _ = lfc.remove(table_path.prefix()); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Haven't delved into it deeply, but it seems related to this upstream issue:
apache/datafusion#19573
lonless9
commented
Jan 26, 2026
Comment on lines
+149
to
+155
| fn update_cache_limit(&self, _limit: usize) { | ||
| // TODO: support dynamic update of cache limit | ||
| } | ||
|
|
||
| fn update_cache_ttl(&self, _ttl: Option<Duration>) { | ||
| // TODO: support dynamic update of cache ttl | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Moka likely does not support this option, and refactoring here to use locks for protection doesn't seem like a good idea either. So I guess we can leave it as a TODO for now.
lonless9
commented
Jan 26, 2026
| rules.push(limit_push_past_windows()); | ||
| rules.push(Arc::new(LimitPushdown::new())); | ||
| rules.push(Arc::new(ProjectionPushdown::new())); | ||
| rules.push(Arc::new(PushdownSort::new())); |
Contributor
Author
There was a problem hiding this comment.
lonless9
commented
Jan 26, 2026
| rules.push(Arc::new(OptimizeAggregateOrder::new())); | ||
| rules.push(Arc::new(ProjectionPushdown::new())); | ||
| rules.push(Arc::new(CoalesceBatches::new())); | ||
| rules.push(Arc::new(CoalesceAsyncExecInput::new())); |
Contributor
Author
There was a problem hiding this comment.
lonless9
commented
Jan 26, 2026
| datafusion-functions = { version = "52.1.0" } | ||
| datafusion-functions-nested = { version = "52.1.0" } | ||
| datafusion-physical-expr = { version = "52.1.0" } | ||
| datafusion-session = { version = "52.1.0" } |
Contributor
Author
There was a problem hiding this comment.
I plan to later change all imports of session from datafusion-catalog to imports from datafusion-session.
linhr
approved these changes
Jan 27, 2026
Comment on lines
+11
to
+13
| /// Unlike a regular `Filter` node, this node is used in streaming plan rewriting | ||
| /// to avoid DataFusion optimizer rules (e.g. repartition insertion) that can make | ||
| /// bounded streaming queries unexpectedly slow. |
Contributor
There was a problem hiding this comment.
Interesting. I'll probably look into it deeper to understand what's going on, but I think this extension is good to have for now.
Contributor
Author
|
Okay, I've handle some of the comments in #1255 |
This was referenced Jan 29, 2026
wudihero2
pushed a commit
to wudihero2/sail
that referenced
this pull request
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
52.0.0(Dec 2025 / Jan 2026) apache/datafusion#18566