Skip to content

Allow custom (shorter) timeouts #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MCOfficer opened this issue Apr 7, 2020 · 3 comments · Fixed by #77
Closed

Allow custom (shorter) timeouts #42

MCOfficer opened this issue Apr 7, 2020 · 3 comments · Fixed by #77
Assignees
Labels
enhancement help-wanted Help wanted (feedback, logs, ...)

Comments

@MCOfficer
Copy link

MCOfficer commented Apr 7, 2020

I recently recommended apt-spy2 for CI environments, to ensure apt-get install does not fail, ever. The usecase is just to find a working mirror, quickly.

Trying it out, i noticed that apt-spy2 check stalls for about 2 minutes because a single mirror in the list is unreachable. Some of our CI runs complete in less time, so it would be cool if one could speed up apt-spy2 check. In my opinion, the best way to do so would be a custom timeout - set it to 3s and you get a working mirror almost immediately.

Edit: this probably applies to all other subcommands as well.

@till
Copy link
Member

till commented May 17, 2021

@MCOfficer let me know if you want to start a PR, happy to help.

@till till added enhancement help-wanted Help wanted (feedback, logs, ...) labels May 17, 2021
@MCOfficer
Copy link
Author

@MCOfficer let me know if you want to start a PR, happy to help.

I'm not familiar with ruby and don't have time to get into it, sorry. Here's hoping someone else picks it up.

@till
Copy link
Member

till commented May 17, 2021

@MCOfficer Could be as simple as this: https://stackoverflow.com/a/26066923 (in the downloader class).

@till till mentioned this issue Dec 23, 2021
@till till closed this as completed in #77 Dec 23, 2021
@till till self-assigned this Dec 23, 2021
till added a commit that referenced this issue Dec 24, 2021
 - fixes ruby 3+ errors (uncovered with 0.7.2 release)
 - sets explicit ruby version dependency in Gemfile
 - adds test more coverage
 - e2e test of the tool
 - fixes timeout issues (10 second timeout) #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help-wanted Help wanted (feedback, logs, ...)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants