Superagent downgrading

[rimiti]

Hello,

To quickly unblock the situation, I propose to downgrade the superagent version.

Details of this PR:

• Test included to assert using promises (fail with superagent v4.x).
• Superagent downgraded to "^3.8.3".

Related issues:

• From 3.x to 4.x, is there a new way to use request() ? #557
• expect(!2xx) throws exception #556

Current investigation:
The line causing this promise issue in superagent: https://github.com/visionmedia/superagent/blob/master/lib/request-base.js#L245

If this line is commented, supertest works fine with superagent v4.

Note: I am very busy to investigate for now, if anyone has time to work on a new pull request (regarding the safe update of superagent), it would be great. Otherwise I will do it as soon as I have time;

[coveralls]

Pull Request Test Coverage Report for Build 395

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 97.297%

---

Totals
Change from base Build 389:	0.0%
Covered Lines:	137
Relevant Lines:	141

---

💛 - Coveralls

[rimiti]

@gjohnson What do you think about that? 🤓

[gjohnson]

I suppose this is really the only path forward. My bad on not catching this last go around. In the next-release we should make sure we use a tag in npm or something so it's flagged as unstable.

[gjohnson]

@rimiti I'll let you merge and release. We'll discuss a path forward on slack.

[rimiti]

it should have been tagged as v4.0.0-alpha.1 but we can rewrite the past.

[Floby]

Thank all of you. At least this was published on a major/breaking version anyway. Could be worse. :)

[bajtos]

FWIW, I believe the actual root cause of the problem is in superagent and should be already fixed by my pull request ladjs/superagent#1468. Once a new version of superagent is released, we should be good to use superagent@4 in supertest again.

[artparks]

any news on upgrading this?

[mdhornet90]

Checked out supertest on my machine and updated its dependency on superagent first to 4.0.0, and confirmed that there was a failing test due to a timeout being exceeded (should assert using promises). I then changed the dependency version to 5.1.0 (which includes @bajtos fix) and confirmed that all tests pass. Can this move forward or does there need to be more verification?

[rimiti]

I'll try to pre-release a version today.
Thanks @bajtos and @mdhornet90