Fix http2 request with node 10.

ladjs · Sep 13, 2018 · 1db3a4b · 1db3a4b
1 parent b08371c
commit 1db3a4b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -14,4 +14,10 @@ matrix:
   include:
     - node_js: "9"
       env: BROWSER=1
+  include:
+    - node_js: "10"
+      env: HTTP2_TEST=1
 
+before_install:
+  - "test -z $(echo $HTTP2_TEST) || npm install https://github.com/sogaani/express.git#initial-support-http2"
+  - "rm -f package-lock.json npm-shrinkwrap.json"
diff --git a/lib/node/http2wrapper.js b/lib/node/http2wrapper.js
@@ -80,7 +80,9 @@ Request.prototype.createUnixConnection = function (authority, options) {
 }
 
 Request.prototype.setNoDelay = function (bool) {
-  this.session.socket.setNoDelay(bool);
+  // We can not use setNoDelay with HTTP/2.
+  // Node 10 limits http2session.socket methods to ones safe to use with HTTP/2.
+  // See also https://nodejs.org/api/http2.html#http2_http2session_socket
 }
 
 Request.prototype.getFrame = function () {

diff --git a/package.json b/package.json
@@ -44,7 +44,7 @@
     "body-parser": "^1.18.2",
     "browserify": "^16.2.0",
     "cookie-parser": "^1.4.3",
-    "express": "^4.16.3",
+    "express": "git+https://github.com/sogaani/express.git#initial-support-http2",
     "express-session": "^1.15.6",
     "marked": "^0.5.0",
     "mocha": "^3.5.3",