integration: add input method section #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolatis
reviewed
Mar 10, 2024
|
Looks really nice, thanks for the excellent write up. |
|
@tokyo4j Now that |
What is the reference here... |
Consolatis
reviewed
Mar 23, 2024
|
Oh, what a stupid mistake... I meant |
Consolatis
reviewed
Mar 24, 2024
Consolatis
reviewed
Mar 24, 2024
|
One last small nitpick above, other than that this LGTM, I'd vote for the squash-and-merge once the last nitpick is resolved. |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended for merging after
0.17.20.7.2 is released.As I'm a non-native English speaker, any nitpicking is welcome.