Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: remove screenshot and reference to WIP #56

Merged
merged 1 commit into from
Apr 29, 2024
Merged

README: remove screenshot and reference to WIP #56

merged 1 commit into from
Apr 29, 2024

Conversation

johanmalm
Copy link
Collaborator

No description provided.

@stefonarch
Copy link
Contributor

Change screenshot instead?

immagine

@johanmalm
Copy link
Collaborator Author

Feels like it's going through a period of change, so thought we could hang on a bit until it stabilizes

@redtide
Copy link
Contributor

redtide commented Apr 28, 2024

There is a link to the screenshot also in Config.cmake

@johanmalm
Copy link
Collaborator Author

There is a link to the screenshot also in Config.cmake

So, what should I do with Config.cmake when removing/changing the screenshot.

@stefonarch
Copy link
Contributor

stefonarch commented Apr 28, 2024

It is used in apps like discover and generates /usr/share/metainfo/labwc_tweaks.appdata.xml .

Ideally there should be always a screenshot with the same name.

EDIT: didn't look at the filename and path, weird.
For example qps is https://raw.githubusercontent.com/lxqt/qps/master/qps.png

@redtide
Copy link
Contributor

redtide commented Apr 28, 2024

There is a link to the screenshot also in Config.cmake

So, what should I do with Config.cmake when removing/changing the screenshot.

an empty string until it will be replaced later some day with the new screenshot

@johanmalm
Copy link
Collaborator Author

Okay. Have tweaked Config.cmake too.

Suggest we add a screenshot to the repo when the client has matured a little more.

@johanmalm johanmalm merged commit 6790a88 into master Apr 29, 2024
4 checks passed
@johanmalm johanmalm deleted the README branch April 29, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants