Parse png buttons

[johanmalm]

@Consolatis - any high level review comments?

TODO

• Parse svg icons (come themes contain a file:///.....svg instead of the base64)
• Remove old icons when parsing new theme

[Consolatis]

Maybe you could try to also parse the mime type, e.g. image/png to either

• ensure you got some actual png file there
• or if its in a different format, you could try to load it with some external library (Pillow for example, should be packaged basically everywhere) and then save it as png.

The b64decode part (or the whole line parsing) should likely be encapsulated in a try / except block.

When looking at it from a higher level, maybe something generic like get_attribute_value(lines, "button.close.titlebutton", "background-image") might be useful. That could then be called by create_one_icon() so all that is left to do there is parse the actual value / do the b64 decoding / store as png.

[johanmalm]

Thanks. Will carry on another day.

Re: svg icons, we could add svg support directly to labwc too. Following recent refactoring it wouldn't be many lines 😄

Probably just this:

https://github.com/jgmenu/jgmenu/blob/95019972da73cc71680ea30ebb4f8a8a3212f1b4/src/icon.c#L101-L136

[Consolatis]

Re: svg icons, we could add svg support directly to labwc too. Following recent refactoring it wouldn't be many lines 😄

Sounds good to me, doing it in labwc might even be beneficial because we could link this up to the autoscaling buffer and thus newly render it based on output scale changes, similar to the title. Just an idea, we don't have to do that.