Repository navigation
feat(groups): facilitator with bounded moves (I12) #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5966172
feat(groups): voting with structural ballot independence (I14)
ginccc 6173e48
fix(test): PhaseType enum-count pin now includes VOTE
ginccc 51a7092
fix(groups): I14 review round 1 - budgeted tiebreak, tie epsilon, dis…
ginccc 9c84783
feat(groups): humans as group members - AWAITING_HUMAN_INPUT turns (I6)
ginccc a9f1598
fix(groups): I6 review round 1 - member read access, resume hygiene
ginccc 41de0a5
Merge branch 'feat/group-i6-human-members' into feat/group-i12-facili…
ginccc 87f5002
feat(groups): facilitator with bounded moves (I12)
ginccc 86f4376
fix(groups): I12 review round 1 - TOCTOU snapshot, encapsulated exten…
ginccc 0eb199e
fix(groups): facilitator checkpoint consults before the decision block
ginccc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Clarify the
HUMAN_DECIDESstatus now that I6 ships in the same change.Lines 202-203 state that
HUMAN_DECIDES"is reserved for human group members (I6) and is rejected at save time until then". The next section documents human group members as available.AgentGroupStore.validateVotePhasesstill rejectsHUMAN_DECIDESwith the message "needs human group members (I6), which are not available yet". A reader who just enabled a HUMAN member will expectHUMAN_DECIDESto work. State explicitly thatHUMAN_DECIDESremains unimplemented in this release even with human members configured.🤖 Prompt for AI Agents