bugfix: index.html changes and testing if the deploy script for the e… - #519
Merged
Conversation
…ddi manager works correctly
Contributor
📝 WalkthroughWalkthroughThis PR adds 16 new minified language support bundles to the frontend assets directory. It introduces an LSP adapter infrastructure that all language modes depend on, 11 language tokenizer/grammar definitions for syntax highlighting and editor behaviors, and four language mode bundles that manage worker lifecycle and language-service providers. HTML entry files are updated to redirect and reference new hashed bundle filenames. ChangesLanguage Support Bundles and Entry Point Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
ginccc
approved these changes
Jun 4, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/main/resources/META-INF/resources/index.html (1)
6-8: 💤 Low valueDual redirect mechanism is redundant but acceptable.
The page uses both a meta refresh tag (line 6) and a JavaScript redirect (line 8) to the same destination. While redundant, this provides a defensive fallback for older browsers or environments where JavaScript is disabled. If this is intentional, consider adding a comment explaining the dual approach. Otherwise, you may remove one mechanism.
♻️ Optional: Remove redundant meta refresh if JavaScript redirect is sufficient
- <meta http-equiv="refresh" content="0;url=/manage"> <link rel="icon" href="/img/favicon.ico"> <script>window.location.replace('/manage');</script>Alternatively, keep both and add a comment:
<title>EDDI — Redirecting to Manager</title> + <!-- Meta refresh provides fallback when JavaScript is disabled --> <meta http-equiv="refresh" content="0;url=/manage"> <link rel="icon" href="/img/favicon.ico"> + <!-- Primary redirect via JavaScript to prevent back-button loop --> <script>window.location.replace('/manage');</script>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/resources/META-INF/resources/index.html` around lines 6 - 8, The file currently performs two redirects: the meta refresh tag (meta http-equiv="refresh" content="0;url=/manage") and the JS redirect (window.location.replace('/manage')); decide whether to keep both for fallback or remove one. If keeping both, add a brief HTML comment above the meta/script explaining the intentional dual-redirect fallback for non-JS browsers; if removing redundancy, delete the meta refresh line and keep the JS redirect (or vice versa) so only one redirect mechanism remains. Target the meta tag and the script block (window.location.replace) when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/main/resources/META-INF/resources/index.html`:
- Around line 6-8: The file currently performs two redirects: the meta refresh
tag (meta http-equiv="refresh" content="0;url=/manage") and the JS redirect
(window.location.replace('/manage')); decide whether to keep both for fallback
or remove one. If keeping both, add a brief HTML comment above the meta/script
explaining the intentional dual-redirect fallback for non-JS browsers; if
removing redundancy, delete the meta refresh line and keep the JS redirect (or
vice versa) so only one redirect mechanism remains. Target the meta tag and the
script block (window.location.replace) when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b2336388-29ef-49a5-80d4-629afb7843ab
📒 Files selected for processing (21)
src/main/resources/META-INF/resources/assets/cssMode-D8JTVQLU.jssrc/main/resources/META-INF/resources/assets/freemarker2-BiIjQAxc.jssrc/main/resources/META-INF/resources/assets/handlebars-D2TOOSOX.jssrc/main/resources/META-INF/resources/assets/html-tZReBU-g.jssrc/main/resources/META-INF/resources/assets/htmlMode-BH9kD7xO.jssrc/main/resources/META-INF/resources/assets/index-CJdl8JdC.csssrc/main/resources/META-INF/resources/assets/index-DpBjm1jY.jssrc/main/resources/META-INF/resources/assets/index-cMpUMLNo.csssrc/main/resources/META-INF/resources/assets/javascript-BEPXgjMd.jssrc/main/resources/META-INF/resources/assets/jsonMode-GDfcS83-.jssrc/main/resources/META-INF/resources/assets/liquid-DEeaS_EA.jssrc/main/resources/META-INF/resources/assets/lspLanguageFeatures-iTapPTXa.jssrc/main/resources/META-INF/resources/assets/mdx-fIs3Hl06.jssrc/main/resources/META-INF/resources/assets/python-BldTDRww.jssrc/main/resources/META-INF/resources/assets/razor-DON-1Dov.jssrc/main/resources/META-INF/resources/assets/tsMode-B7LVotFm.jssrc/main/resources/META-INF/resources/assets/typescript-E8i5rMS1.jssrc/main/resources/META-INF/resources/assets/xml-CL4gL865.jssrc/main/resources/META-INF/resources/assets/yaml-CFcMopXx.jssrc/main/resources/META-INF/resources/index.htmlsrc/main/resources/META-INF/resources/manage.html
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ddi manager works correctly
Summary
index.html was a copy of manage.html due to a bug in the auth implementation of keycloak. This is fixed now
Type of Change
Related Issue
Closes #
Changes Made
How to Test
Checklist
./mvnw clean verify -DskipITs)Summary by CodeRabbit
New Features
Updates