Issues/eddi 2 - #26
Merged
Merged
Conversation
ginccc
approved these changes
Mar 5, 2017
ginccc
added a commit
that referenced
this pull request
Jul 3, 2026
…s, scale poller, add pause retention Findings 5, 7, 17, 26, 32, 44: - #5 (security): RestScheduleStore refuses manual fire of HITL timeout schedules (409 for everyone, incl. admins), requires eddi-admin to mutate/disable/delete them (403), and redacts them from non-admins. PostgresScheduleStore gains a metadata JSONB column (parity with Mongo's full-doc persistence) so the HITL fast-path and the guard work on both backends. - #7: AgentDeploymentManagement idle sweep skips AWAITING_HUMAN instead of force-ENDing them via a raw non-CAS write; logs spared count. - #17: configurable poll batch size (both stores) + concurrent virtual-thread dispatch of claimed schedules with per-fire error isolation; CAS claim stays before dispatch. - #26/#44: RestConversationStore routes paused end/permanent-delete through the HITL-aware IConversationService.endConversation. - #32: optional pause-retention sweep (eddi.hitl.pending.max-age, default OFF) in HitlCrashRecoveryObserver via cancelConversation; reuses scheduling infra. - CodeQL: silence unused @observes StartupEvent param (required CDI trigger). Pure JUnit/Mockito tests added for each. Compile + test-compile green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds client generation capabilities.