Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kafka monitor #4349

Merged
merged 1 commit into from
Nov 27, 2023
Merged

add kafka monitor #4349

merged 1 commit into from
Nov 27, 2023

Conversation

wallyxjh
Copy link
Contributor

@wallyxjh wallyxjh commented Nov 27, 2023

🤖[deprecated] Generated by Copilot at 1e015ee

Summary

🗺️📊🚀

This pull request adds support for Kafka metrics to the service/database package. It defines a new map of Prometheus queries for Kafka pods in api/req.go and uses it in the GetQuery function in request/req.go.

api package
adds Kafka map for metrics
autumn harvest time

Walkthrough

  • Add a new map variable Kafka to store Prometheus queries for Kafka metrics (link)
  • Implement a new case in the GetQuery function to handle requests for kafka type and assign the result to the corresponding query from the Kafka map (link)

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1036
✅ Successful 367
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 668
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 27, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5330a70) 65.45% compared to head (1e015ee) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4349   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzjin zzjin added this to the v5.0 milestone Nov 27, 2023
@zzjin zzjin merged commit ba71f1d into labring:main Nov 27, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants