Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cloud port #4271

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Fix/cloud port #4271

merged 2 commits into from
Nov 8, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Nov 8, 2023

🤖 Generated by Copilot at 2b70794

Summary

🔧🚢🌐

This pull request enhances the cloud installation of sealos by allowing single-node deployments and custom port configurations. It also updates the Kubefile and the appcr.yaml.tmpl templates of the terminal, cronjob, and license providers to use the new cloudPort variable.

To deploy sealos on the cloud
We renamed port to avoid a crowd
Of other ports in use
That might cause some abuse
And updated deploy.yaml and appcr to be proud

Walkthrough

  • Rename port environment variable to cloudPort to avoid confusion with other ports (link)
  • Update deploy.yaml.tmpl template to use cloudPort for PORT environment variable of terminal container (link)
  • Update appcr.yaml.tmpl templates for cronjob and license providers to append cloudPort to url and icon fields if not empty (link, link)
  • Update install.sh script to skip asking for node_ips input if single is set to y for single-node installation (link)
  • Update install.sh script to patch ingress-nginx-controller daemonset to use cloudPort as https-port argument if not empty (link)

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 981
✅ Successful 312
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 668
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 8, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@bxy4543 bxy4543 added this to the v5.0 milestone Nov 8, 2023
@bxy4543 bxy4543 merged commit c4e8187 into labring:main Nov 8, 2023
81 checks passed
@bxy4543 bxy4543 deleted the fix/cloud_port branch November 8, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants