Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize ctx data definition #1558

Merged
merged 5 commits into from
Oct 11, 2023
Merged

feat: optimize ctx data definition #1558

merged 5 commits into from
Oct 11, 2023

Conversation

nightwhite
Copy link
Collaborator

No description provided.

@maslow
Copy link
Member

maslow commented Oct 7, 2023

FunctionContext 应该是 global 的, 不需要单独引入才对。

@maslow maslow closed this Oct 7, 2023
@nightwhite
Copy link
Collaborator Author

实际测试结果是,这么引入和global自动引入的是不一样的

@maslow maslow reopened this Oct 7, 2023
@maslow
Copy link
Member

maslow commented Oct 7, 2023

那应该是前端没有更新最新的类型 @newfish-cmyk 跟进一下

@cla-assistant
Copy link

cla-assistant bot commented Oct 8, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ nightwhite
✅ newfish-cmyk
❌ actions-user
You have signed the CLA already but the status is still pending? Let us recheck it.

@cla-assistant
Copy link

cla-assistant bot commented Oct 8, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nightwhite
❌ actions-user
You have signed the CLA already but the status is still pending? Let us recheck it.

@0fatal 0fatal merged commit b3ecb45 into labring:main Oct 11, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants