Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: laf doc preview during pr #1472

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

aFlyBird0
Copy link
Contributor

@aFlyBird0 aFlyBird0 commented Aug 15, 2023

Note: Blocked by some issues now

Summary

complete #1063

  • open/reopen PR: create bucket & website, deploy
  • update PR: redeploy
  • close PR: delete

Details(Screenshots)

image image

link: aFlyBird0#4

Blocked Info

  1. blocked by [bug/cli] Failed to delete website with Laf CLI #1469
  2. GitHub Action Secrets to be added @maslow (Since informing users about the access address is necessary during the preview, app ID and other information will be exposed. It is recommended to use a completely new, low-privileged application.)
${{ secrets.LAF_CI_DOCS_PREVIEW_PAT }}
${{ secrets.LAF_CI_DOCS_PREVIEW_APPID }}
${{ secrets.LAF_CI_DOCS_PREVIEW_API_URL }}

@aFlyBird0 aFlyBird0 force-pushed the ci-doc-preview branch 3 times, most recently from e521572 to d0a7fa3 Compare August 15, 2023 10:10
@aFlyBird0 aFlyBird0 changed the title [WIP] Ci doc preview ci: laf doc preview during pr Aug 15, 2023
@aFlyBird0
Copy link
Contributor Author

aFlyBird0 commented Aug 15, 2023

Currently, each PR has its own separate bucket, which makes automatic DNS configuration challenging. If we place all the PRs into different directories within the same bucket, we can avoid exposing the app ID (by manually configuring DNS). However, this approach would make the implementation relatively more complex.

However, block by #1464

中文版评论:

目前是每个pr单独一个bucket,所以会导致dns难以自动配置。如果我们将所有的pr放到同一个bucket的不同目录中,就可以避免appid暴露(手动设置一次dns)。不过这样的话,实现也会相对复杂些。

阻塞于:#1464

cc @maslow

@aFlyBird0 aFlyBird0 marked this pull request as ready for review August 15, 2023 10:16
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 15, 2023
@maslow maslow merged commit c422231 into labring:main Aug 22, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants