Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history in classifyQuestion and extract modules #1012

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

Fengrui-Liu
Copy link
Contributor

It seems that classifyQuestion and extract modules do not process the chat histories correctly.

It passes Object rather than the text to the LLM

screenshot-20240318-171935

@c121914yu
Copy link
Collaborator

c121914yu commented Mar 18, 2024

const { text, files } = chatValue2RuntimePrompt(prompt);
调用下这个方法进行拆分,会合并text。

参考文件路径:projects/app/src/pages/api/core/chat/chatTest.ts

@Fengrui-Liu
Copy link
Contributor Author

const { text, files } = chatValue2RuntimePrompt(prompt); 调用下这个方法进行拆分,会合并text。

参考文件路径:projects/app/src/pages/api/core/chat/chatTest.ts

Done

@c121914yu
Copy link
Collaborator

thanks

@c121914yu c121914yu merged commit 6d4b331 into labring:main Mar 18, 2024
2 checks passed
@Fengrui-Liu Fengrui-Liu deleted the chatHist_bug_fixes branch March 18, 2024 14:51
c121914yu pushed a commit to c121914yu/FastGPT that referenced this pull request Mar 19, 2024
* Fix history in classifyQuestion and extract modules

* Add chatValue2RuntimePrompt import and update text formatting
c121914yu added a commit to c121914yu/FastGPT that referenced this pull request Mar 19, 2024
* fix docker-compose download url (labring#994)

original code is a bad url with '404 NOT FOUND' return. 
fix docker-compose download url, add 'v' before docker-compose version

* Update ai_settings.md (labring#1000)

* Update configuration.md

* Update configuration.md

* Fix history in classifyQuestion and extract modules (labring#1012)

* Fix history in classifyQuestion and extract modules

* Add chatValue2RuntimePrompt import and update text formatting

* flow controller to packages

* fix: rerank select

* modal ui

* perf: modal code path

* point not sufficient

* feat: http url support variable

* fix http key

* perf: prompt

* perf: ai setting modal

* simple edit ui

---------

Co-authored-by: entorick <[email protected]>
Co-authored-by: liujianglc <[email protected]>
Co-authored-by: Fengrui Liu <[email protected]>
c121914yu added a commit to c121914yu/FastGPT that referenced this pull request Mar 20, 2024
* fix docker-compose download url (labring#994)

original code is a bad url with '404 NOT FOUND' return.
fix docker-compose download url, add 'v' before docker-compose version

* Update ai_settings.md (labring#1000)

* Update configuration.md

* Update configuration.md

* Fix history in classifyQuestion and extract modules (labring#1012)

* Fix history in classifyQuestion and extract modules

* Add chatValue2RuntimePrompt import and update text formatting

* flow controller to packages

* fix: rerank select

* modal ui

* perf: modal code path

* point not sufficient

* feat: http url support variable

* fix http key

* perf: prompt

* perf: ai setting modal

* simple edit ui

---------

Co-authored-by: entorick <[email protected]>
Co-authored-by: liujianglc <[email protected]>
Co-authored-by: Fengrui Liu <[email protected]>
c121914yu added a commit that referenced this pull request Mar 21, 2024
* feat: stop toolCall and rename some field. (#46)

* perf: node delete tip;pay tip

* fix: toolCall cannot save child answer

* feat: stop tool

* fix: team modal

* fix feckbackMoal  auth bug (#47)

* 简单的支持提示词运行tool。优化workflow模板 (#49)

* remove templates

* fix: request body undefined

* feat: prompt tool run

* feat: workflow tamplates modal

* perf: plugin start

* 4.7 (#50)

* fix docker-compose download url (#994)

original code is a bad url with '404 NOT FOUND' return.
fix docker-compose download url, add 'v' before docker-compose version

* Update ai_settings.md (#1000)

* Update configuration.md

* Update configuration.md

* Fix history in classifyQuestion and extract modules (#1012)

* Fix history in classifyQuestion and extract modules

* Add chatValue2RuntimePrompt import and update text formatting

* flow controller to packages

* fix: rerank select

* modal ui

* perf: modal code path

* point not sufficient

* feat: http url support variable

* fix http key

* perf: prompt

* perf: ai setting modal

* simple edit ui

---------

Co-authored-by: entorick <[email protected]>
Co-authored-by: liujianglc <[email protected]>
Co-authored-by: Fengrui Liu <[email protected]>

* fix team share redirect to login (#51)

* feat: support openapi import plugins (#48)

* feat: support openapi import plugins

* feat: import from url

* fix: add body params parse

* fix build

* fix

* fix

* fix

* tool box ui (#52)

* fix: training queue

* feat: simple edit tool select

* perf: simple edit dataset prompt

* fix: chatbox tool ux

* feat: quote prompt module

* perf: plugin tools sign

* perf: model avatar

* tool selector ui

* feat: max histories

* perf: http plugin import (#53)

* perf: plugin http import

* chatBox ui

* perf: name

* fix: Node template card (#54)

* fix: ts

* setting modal

* package

* package

* feat: add plugins search (#57)

* feat: add plugins search

* perf: change http plugin header input

* Yjl (#56)

* perf: prompt tool call

* perf: chat box ux

* doc

* doc

* price tip

* perf: tool selector

* ui'

* fix: vector queue

* fix: empty tool and empty response

* fix: empty msg

* perf: pg index

* perf: ui tip

* doc

* tool tip

---------

Co-authored-by: yst <[email protected]>
Co-authored-by: entorick <[email protected]>
Co-authored-by: liujianglc <[email protected]>
Co-authored-by: Fengrui Liu <[email protected]>
Co-authored-by: heheer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants