Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BA-433): Misuse of the walrus operator when taking ModifyEndpoint input #3337

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

achimnol
Copy link
Member

resolves #3336 (BA-433)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@achimnol achimnol added this to the 24.12 milestone Dec 31, 2024
@achimnol achimnol self-assigned this Dec 31, 2024
@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Dec 31, 2024
@achimnol achimnol force-pushed the fix/mishandling-of-walrus-operator branch from f741695 to 49d0e7b Compare December 31, 2024 06:07
@github-actions github-actions bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Dec 31, 2024
@achimnol
Copy link
Member Author

@ironAiken2 reported this issue and has confirmed the issue is fixed.

@achimnol achimnol added this pull request to the merge queue Dec 31, 2024
Merged via the queue into main with commit 671843a Dec 31, 2024
23 checks passed
@achimnol achimnol deleted the fix/mishandling-of-walrus-operator branch December 31, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The replica count of model service endpoints is always set to 1 regardless of user input
1 participant