Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade ruff from 0.1.11 to 0.4.1 #2053

Closed
wants to merge 3 commits into from

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Apr 23, 2024

chore(deps): Upgrade ruff from 0.1.11 to 0.4.1

  • Apply the new formatting rule (e.g., format inside f-string placeholders)
  • Convert single-quotes in f-string placeholders to double-quotes
  • WARNING: When you backport these codes to releases using Python 3.11
    or older, you may have to edit the codes to make it compliant to
    the legacy f-string placeholder mini-language.

Note

Currently this PR is on hold until astral-sh/ruff#11056 is resolved.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

- Apply formatting rules inside f-string placeholders
- Convert single-quotes in f-string placeholders to double-quotes
- WARNING: When you backport these codes to releases using Python 3.11
  or older, you may have to edit the codes to make it compliant to
  the legacy f-string placeholder mini-language.
Copy link

graphite-app bot commented Apr 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:client Related to Client component comp:manager Related to Manager component comp:storage-proxy Related to Storage proxy component comp:webserver Related to Web Server component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC labels Apr 23, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @achimnol and the rest of your teammates on Graphite Graphite

@achimnol achimnol added the action:on hold Hold it. Wait for the restart. label Apr 23, 2024
@achimnol achimnol added this to the 23.09 milestone Apr 23, 2024
@achimnol achimnol added the skip:changelog Make the action workflow to skip towncrier check label Apr 23, 2024
@achimnol
Copy link
Member Author

achimnol commented Aug 3, 2024

We will revisit this later using more recent version of Ruff (currently it's 0.5.6) after astral-sh/ruff#11056 and astral-sh/ruff#6591 is resolved.

@achimnol achimnol closed this Aug 3, 2024
@achimnol achimnol deleted the chore/upgrade-ruff-to-0.4 branch August 3, 2024 10:22
@achimnol achimnol mentioned this pull request Sep 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action:on hold Hold it. Wait for the restart. comp:client Related to Client component comp:manager Related to Manager component comp:storage-proxy Related to Storage proxy component comp:webserver Related to Web Server component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant