driver/power: Add support for Gude 87-1210-18 #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file has been created with CRLF, but all other files in this repo seem to be LF-only. This changes the line-ending of the file to LF-only. Signed-off-by: Chris Fiege <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1534 +/- ##
========================================
- Coverage 56.6% 56.6% -0.1%
========================================
Files 168 168
Lines 13033 13033
========================================
- Hits 7385 7384 -1
- Misses 5648 5649 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jluebbe
requested changes
Oct 30, 2024
Signed-off-by: Chris Fiege <[email protected]>
The Gude Expert Power Control 87-1210-18 is a vertical 20 port power distribution unit: https://gude-systems.com/en/products/expert-power-control-87-1210/ It uses the same HTTP-API, as the Gude Power Control 8031 - but simply has more ports. This commit adds support and documentation for this device. Loosing the restrictions on the `index` makes it possible to re-use this driver. Setting a non-existent port fails silently. But getting a non-existent port will cause an exception. I deem this behavior acceptable, since a new device will be tested during hardware setup anyway. So we do not need to check the actual number of ports during normal operation. Signed-off-by: Chris Fiege <[email protected]>
|
Updated the commit messages as suggested. |
Emantor
approved these changes
Oct 30, 2024
jluebbe
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Gude Expert Power Control 87-1210-18 is a vertical 20 port power
distribution unit:
https://gude-systems.com/en/products/expert-power-control-87-1210/
It uses the same HTTP-API, as the Gude Power Control 8031 - but simply
has more ports.
This PR adds support and documentation for this device.
While I am on it: Re-format the file with
ruffand replace the Windows Line-Endings.Change has been tested locally against a Gude 87-1210-18.
Checklist