Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the brightness contrast adjustment #1443

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

PairZhu
Copy link
Contributor

@PairZhu PairZhu commented May 21, 2024

Specify the encoding parameters of open to be compatible with more operating systems (such as windows) in get_long_description
Unify the naming style of variables, add specific numerical display labels, and speed up the response speed of adjustments (especially for large images)

@wkentaro
Copy link
Member

what error do you get on windows from get_long_description ?

PairZhu and others added 4 commits June 13, 2024 19:46
`open` use different default encodings on different operating systems
Unify the naming style of variables, add specific numerical display labels, and speed up the response speed of adjustments (especially for large images)
@wkentaro
Copy link
Member

what error do you get on windows from get_long_description ?

Merging this PR without this for now.

Please open a new one if need

@wkentaro wkentaro merged commit 97bee58 into labelmeai:main Jun 13, 2024
6 checks passed
@PairZhu
Copy link
Contributor Author

PairZhu commented Jun 13, 2024

what error do you get on windows from get_long_description ?

I did not test other language versions of windows systems, at least in the Chinese version, the default encoding of python's open function is' gbk'

@wkentaro
Copy link
Member

you can't install due to that?

@PairZhu
Copy link
Contributor Author

PairZhu commented Jun 13, 2024

you can't install due to that?

I can't

@wkentaro
Copy link
Member

I see. The Windows in CI is passing, so curious to know why.

Can you give me some print of your encoding and the error message?

@PairZhu
Copy link
Contributor Author

PairZhu commented Jun 14, 2024

I see. The Windows in CI is passing, so curious to know why.

Can you give me some print of your encoding and the error message?

PS C:\Users\11153\Documents\Code\GitHub\labelme> pip install -e .
Looking in indexes: https://pypi.tuna.tsinghua.edu.cn/simple
Obtaining file:///C:/Users/11153/Documents/Code/GitHub/labelme
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [12 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "C:\Users\11153\Documents\Code\GitHub\labelme\setup.py", line 160, in <module>
          main()
        File "C:\Users\11153\Documents\Code\GitHub\labelme\setup.py", line 123, in main
          long_description=get_long_description(),
                           ^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\11153\Documents\Code\GitHub\labelme\setup.py", line 73, in get_long_description
          long_description = f.read()
                             ^^^^^^^^
      UnicodeDecodeError: 'gbk' codec can't decode byte 0x97 in position 698: illegal multibyte sequence
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants